Skip to content

Renaming harmonization, notes on breaking changes #3

@JulianCataldo

Description

@JulianCataldo

To be short (will update):

  • ESM > CJS was a breaking change (E.g..default import hack for Rollup ESM setup is not needed anymore)
  • Switching to async was an obvious breaking change

Releases with major for each of these steps were done when migrating thing.
I admit it may have been done in one stroke, so we don't end up with noisy major releases.
It not a big problem for now, because the user base is not there.

Anyway, there is still some harmonization to be done. I've added "css" because besides the HTML minifier, css are also treated with CleanCSS (which is pinned and outdated, BTW). I think it's important to signal that the tool is also treating CSS.

The scheme is :

  • @literals/parser => literalsParser(...)
  • @literals/html-css-minifier => literalsHtmlCssMinifier(...) (TBD)
  • @literals/rollup-plugin-html-css-minifier => literalsHtmlCssMinifier(...) (we skip the rollup-plugin prefix)

Additional packages should follow this.
Some place in the code base are still to be harmonized with this scheme, internally and user-facing.

Maybe it should be the occasion to do it with other potential breaking changes, once and for good.
Like update pinned MagicString, CleanCSS (#2), and/or backporting stuff from asyncliz#56 (comment).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions