Robert8888 patch choices#153
Open
robert8888 wants to merge 6 commits into
Open
Conversation
When it base on choice field the it inherits choice validator which work ok even if there is not choices. Now it's copy 'choices' options from base field.
Together with witch changing base class of DynamicArrayField to ChoiceField now when are available choices in base_field it is rendered as Select.
lint suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing base field for DynamicArrayField adds choices to widget. (even if they are empty).
source
It could work without changing base to ChoiceField by just explicitly coping choices field to self.widget.choices like do it base class. But I changed to get validator inheritance as well.
Now widget checks that it have choices and this choices have not 0 length. If it get choices then it will render subwidget as Select option widget if not then it take TextInput or Textarea or custom. (But this custom have to be onn of select, input or textarea because of js script)