From 4983fa7ca92fbf77b16bc44572a3df39f96a2d6b Mon Sep 17 00:00:00 2001 From: gregoryn22 <56735924+gregoryn22@users.noreply.github.com> Date: Tue, 26 May 2026 13:38:13 -0400 Subject: [PATCH] Add missing display prefs to settings EXPOSED_KEYS ratings_view_mode and 8 show_* card display toggles were tracked in the frontend sf object but absent from EXPOSED_KEYS and UpdateSettingsRequest, so the server silently dropped them on PATCH and never returned them on GET. Preferences appeared to save but reset on every page reload. Co-Authored-By: Claude Sonnet 4.6 --- app/routers/settings.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/app/routers/settings.py b/app/routers/settings.py index e3626ca..2bb6211 100644 --- a/app/routers/settings.py +++ b/app/routers/settings.py @@ -66,6 +66,15 @@ "show_recent_drops", "metadata_refresh_enabled", "metadata_refresh_interval_days", + "ratings_view_mode", + "show_source_badges", + "show_ratings_on_cards", + "show_rating_votes", + "show_progress_bars", + "show_card_meta", + "show_release_group", + "show_tags_on_cards", + "show_card_controls", ] @@ -131,6 +140,15 @@ class UpdateSettingsRequest(BaseModel): show_recent_drops: str | None = None metadata_refresh_enabled: str | None = None metadata_refresh_interval_days: str | None = None + ratings_view_mode: str | None = None + show_source_badges: str | None = None + show_ratings_on_cards: str | None = None + show_rating_votes: str | None = None + show_progress_bars: str | None = None + show_card_meta: str | None = None + show_release_group: str | None = None + show_tags_on_cards: str | None = None + show_card_controls: str | None = None # Sensitive keys that are masked in GET responses. If a PATCH request sends