Skip to content

Fix $IF_IP_FORWARDING check in vmrouter #5

@skalkoto

Description

@skalkoto

Right now, the vmrouter script checks the ip-forwarding interface variable like this:

if [ -n "$IF_IP_FORWARDING" ]; then
...
fi

This means that the variable will be treated as being set if it is non-empty. We should probably check its value like this: [ "$IF_IP_FORWARDING" = 1 ] to prevent errors. People would expect that by setting the value to 0 they would disable ip forwarding.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions