From 6d60a8702f5deef879e4b24a800a50d619c04819 Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 10:23:10 +0800 Subject: [PATCH 1/7] fixed xss --- app/helpers/users_helper.rb | 5 +++-- app/views/events/show.html.erb | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/helpers/users_helper.rb b/app/helpers/users_helper.rb index ed49051..207a6af 100644 --- a/app/helpers/users_helper.rb +++ b/app/helpers/users_helper.rb @@ -7,9 +7,10 @@ def user_avatar_link(user) email_md5 = Digest::MD5.hexdigest(user.email) gravatar_url = "https://www.gravatar.com/avatar/#{email_md5}" - str = "
" + link_to(image_tag(gravatar_url), user_path(user)) + " " + user.display_name + "
" + content_tag(:div, + link_to(image_tag(gravatar_url), user_path(user)) + " " + user.display_name , + :class => "user-link" ) - str.html_safe end end diff --git a/app/views/events/show.html.erb b/app/views/events/show.html.erb index 0e89067..14feb24 100644 --- a/app/views/events/show.html.erb +++ b/app/views/events/show.html.erb @@ -22,7 +22,7 @@
- <%= raw comment.content %> + <%= sanitize comment.content %>
@@ -50,4 +50,4 @@
<%= f.submit "Comment", :class => "btn btn-primary" %>
-<% end %> \ No newline at end of file +<% end %> From 6ef2a746643013ec97277e593418e931a8840bc4 Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 10:40:48 +0800 Subject: [PATCH 2/7] fixed csrf --- app/controllers/application_controller.rb | 2 +- app/views/events/show.html.erb | 2 +- config/routes.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 682a07d..cd6ea53 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -1,6 +1,6 @@ class ApplicationController < ActionController::Base - # protect_from_forgery with: :exception + protect_from_forgery with: :exception helper_method :current_cart diff --git a/app/views/events/show.html.erb b/app/views/events/show.html.erb index 14feb24..2996fec 100644 --- a/app/views/events/show.html.erb +++ b/app/views/events/show.html.erb @@ -29,7 +29,7 @@ <%= comment.created_at.to_s %> <% if current_user && current_user.is_admin? %> - <%= link_to "Highligh", highlight_event_comment_path(@event, comment), :class => "btn btn-default" %> + <%= link_to "Highligh", highlight_event_comment_path(@event, comment), :method => :post, :class => "btn btn-default" %> <% end %> <% if comment.can_deleted_by(current_user) %> diff --git a/config/routes.rb b/config/routes.rb index 2cfd938..a5ccf3e 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -7,7 +7,7 @@ resources :events do resources :comments do member do - get :highlight + post :highlight end end end From 736ced3dfebe5db73ff30b908a5c628b131ba4f2 Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 11:27:37 +0800 Subject: [PATCH 3/7] fixed sql injection --- app/controllers/events_controller.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/controllers/events_controller.rb b/app/controllers/events_controller.rb index 245dece..7c44f28 100644 --- a/app/controllers/events_controller.rb +++ b/app/controllers/events_controller.rb @@ -9,10 +9,11 @@ def show @comments = @event.comments if params[:keyword] - @comments = @comments.where( "comments.content LIKE '%#{params[:keyword]}%'") + keyword = ActiveRecord::Base::connection.quote_string( params[:keyword] ) + @comments = @comments.where( "comments.content LIKE ?", "%#{params[:keyword]}%") end - if params[:sort] + if params[:sort] && ["id DESC", "id ASC"].include?(params[:sort]) # 只有白名单内的参数可以用 @comments = @comments.order(params[:sort]) end From c1277ccf52698178df5c66ac4ab90a0a829a9ac9 Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 11:49:00 +0800 Subject: [PATCH 4/7] fixed mass assignment --- app/controllers/users_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index f1d232d..fd6cac4 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -21,7 +21,7 @@ def update protected def user_params - params.require(:user).permit(:nickname, :role) + params.require(:user).permit(:nickname) end end From cf97894ffb4b17f679fc49d484cce7491becccb0 Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 18:29:27 +0800 Subject: [PATCH 5/7] installed rack-attack --- Gemfile | 1 + Gemfile.lock | 3 ++ config/application.rb | 3 +- config/initializers/rack-attack.rb | 59 ++++++++++++++++++++++++++++++ 4 files changed, 65 insertions(+), 1 deletion(-) create mode 100644 config/initializers/rack-attack.rb diff --git a/Gemfile b/Gemfile index e91c3ae..c261b5a 100644 --- a/Gemfile +++ b/Gemfile @@ -39,6 +39,7 @@ gem 'jbuilder', '~> 2.5' # Use Capistrano for deployment # gem 'capistrano-rails', group: :development +gem 'rack-attack' group :development, :test do gem 'rspec-rails' diff --git a/Gemfile.lock b/Gemfile.lock index 30c443b..8ba62cd 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -98,6 +98,8 @@ GEM orm_adapter (0.5.0) puma (3.8.2) rack (2.0.1) + rack-attack (5.0.1) + rack rack-test (0.6.3) rack (>= 1.0) rails (5.0.2) @@ -200,6 +202,7 @@ DEPENDENCIES jquery-rails listen (~> 3.0.5) puma (~> 3.0) + rack-attack rails (~> 5.0.2) rspec-rails sass-rails (~> 5.0) diff --git a/config/application.rb b/config/application.rb index 2d9ee51..a8be62d 100644 --- a/config/application.rb +++ b/config/application.rb @@ -12,8 +12,9 @@ class Application < Rails::Application # Application configuration should go into files in config/initializers # -- all .rb files in that directory are automatically loaded. config.time_zone = "Beijing" + config.middleware.use Rack::Attack end end -Time::DATE_FORMATS.merge!(:default => '%Y/%m/%d %I:%M %p', :ymd => '%Y/%m/%d') \ No newline at end of file +Time::DATE_FORMATS.merge!(:default => '%Y/%m/%d %I:%M %p', :ymd => '%Y/%m/%d') diff --git a/config/initializers/rack-attack.rb b/config/initializers/rack-attack.rb new file mode 100644 index 0000000..61a40b9 --- /dev/null +++ b/config/initializers/rack-attack.rb @@ -0,0 +1,59 @@ +class Rack::Attack + + throttle('req/ip', :limit => 180, :period => 1.minutes) do |req| + req.ip + end + + ### Prevent Brute-Force Login Attacks ### + + + # The most common brute-force login attack is a brute-force password + + # attack where an attacker simply tries a large number of emails and + + # passwords to see if any credentials match. + + # + + # Another common method of attack is to use a swarm of computers with + + # different IPs to try brute-forcing a password for a specific account. + + + # Throttle POST requests to /login by IP address + + # + + # Key: "rack::attack:#{Time.now.to_i/:period}:logins/ip:#{req.ip}" + + throttle('logins/ip', :limit => 5, :period => 20.seconds) do |req| + if req.path == '/users/sign_in' && req.post? + req.ip + end + end + + # Throttle POST requests to /login by email param + + # + + # Key: "rack::attack:#{Time.now.to_i/:period}:logins/email:#{req.email}" + + # + + # Note: This creates a problem where a malicious user could intentionally + + # throttle logins for another user and force their login requests to be + + # denied, but that's not very common and shouldn't happen to you. (Knock + + # on wood!) + + throttle("logins/email", :limit => 5, :period => 20.seconds) do |req| + if req.path == '/users/sign_in' && req.post? + # return the email if present, nil otherwise + + req.params['email'].presence + end + end + +end From 8dde4197421ffda4f4f0feb79f96a61eaae51f5b Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 18:35:09 +0800 Subject: [PATCH 6/7] installed brakeman --- Gemfile | 1 + Gemfile.lock | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Gemfile b/Gemfile index c261b5a..0ebce8f 100644 --- a/Gemfile +++ b/Gemfile @@ -43,6 +43,7 @@ gem 'rack-attack' group :development, :test do gem 'rspec-rails' + gem 'brakeman' # Call 'byebug' anywhere in the code to stop execution and get a debugger console gem 'byebug', platform: :mri end diff --git a/Gemfile.lock b/Gemfile.lock index 8ba62cd..ec78c9a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -46,6 +46,7 @@ GEM bootstrap-sass (3.3.7) autoprefixer-rails (>= 5.2.1) sass (>= 3.3.4) + brakeman (3.6.2) builder (3.2.3) byebug (9.0.6) coffee-rails (4.2.1) @@ -194,6 +195,7 @@ PLATFORMS DEPENDENCIES bootstrap-sass + brakeman byebug coffee-rails (~> 4.2) devise From da42354edee8246562a4d9dc6275760057bae97b Mon Sep 17 00:00:00 2001 From: JackSparrow008 Date: Tue, 23 May 2017 18:40:56 +0800 Subject: [PATCH 7/7] installed bundler-audit --- Gemfile | 1 + Gemfile.lock | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/Gemfile b/Gemfile index 0ebce8f..96d5608 100644 --- a/Gemfile +++ b/Gemfile @@ -44,6 +44,7 @@ gem 'rack-attack' group :development, :test do gem 'rspec-rails' gem 'brakeman' + gem 'bundler-audit' # Call 'byebug' anywhere in the code to stop execution and get a debugger console gem 'byebug', platform: :mri end diff --git a/Gemfile.lock b/Gemfile.lock index ec78c9a..161f862 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -48,6 +48,9 @@ GEM sass (>= 3.3.4) brakeman (3.6.2) builder (3.2.3) + bundler-audit (0.5.0) + bundler (~> 1.2) + thor (~> 0.18) byebug (9.0.6) coffee-rails (4.2.1) coffee-script (>= 2.2.0) @@ -196,6 +199,7 @@ PLATFORMS DEPENDENCIES bootstrap-sass brakeman + bundler-audit byebug coffee-rails (~> 4.2) devise