Fix agent eligibility check misidentifies bot-authored PRs as human-authored

[mysticgohan1]

Upstream: fullsend-ai/issues/5536

What happens

The fix agent's eligibility check treats bot-authored PRs as human-authored, then skips auto-execution because the fullsend-fix label is absent. The fix agent only runs if a human manually triggers /fs-fix.

Root cause

GitHub represents bot account logins differently depending on the API surface:

Source	Format	Matches \[bot\]$?
github.event.pull_request.user.login (webhook payload)	fullsend-ai-coder[bot]	Yes
gh pr view --json author --jq '.author.login' (GraphQL via CLI)	app/fullsend-ai-coder	No

The dispatch routing uses the event payload (PR_USER_LOGIN), so it correctly routes to the fix stage. But the fix eligibility check re-fetches the author via gh pr view --json author and tests it against \[bot\]$. The app/ prefix format does not match, so the check falls through to require fullsend-fix.

Evidence

PR fullsend-ai#5414 (authored by fullsend-ai-coder[bot]):

• Dispatch run 29835733895 (Jul 21 13:43): routed to fix -- correct.
• Fix run 29835747782 (Jul 21 13:43): failed at "Check fix eligibility" with: Human-authored PR #5414 without 'fullsend-fix' label — skipping bot-triggered fix.
• Zero fix commits on the PR. The review bot's CHANGES_REQUESTED findings were never addressed.

PR fullsend-ai#5450 (authored by fullsend-ai-coder[bot]):

• Review bot posted CHANGES_REQUESTED at 09:13 UTC on Jul 22. Fix agent did not auto-execute.
• Both fix runs were human-triggered via /fs-fix (rh-hemartin at 10:13 and again on Jul 23 at 09:19).

Affected locations

1. fullsend/.github/workflows/reusable-fix.yml lines 314-315 — the fix eligibility check uses gh pr view --json author --jq '.author.login' and tests \[bot\]$.
2. fullsend/.github/workflows/reusable-dispatch.yml lines 1050-1051 — same logic duplicated in per-repo mode.
3. .fullsend/.github/workflows/dispatch.yml — org-level dispatch has the same eligibility check pattern.

The dispatch routing itself (lines 234, 297-300 in the respective files) is not affected because it reads PR_USER_LOGIN from the event payload, which uses the [bot] suffix.

Fix

The PR_AUTHOR bot detection should also match the app/ prefix format returned by the GraphQL API. For example:

if [[ ! "${PR_AUTHOR}" =~ \[bot\]$ ]] && [[ ! "${PR_AUTHOR}" =~ ^app/ ]]; then

Or switch to the REST API (gh api repos/{owner}/{repo}/pulls/{number} --jq '.user.login'), which returns the [bot] suffix matching the event payload format.

Related

• Review agent skipped on bot-authored PRs due to collaborator permission check failing for GitHub App accounts fullsend-ai/fullsend#5188 — same app/ vs [bot] mismatch affects review agent dispatch for bot-authored PRs
• Shouldn't require human to poke the agent when it breaks CI fullsend-ai/fullsend#5350 — user-reported symptom: bot PRs with failing CI require manual /fs-fix

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 7:20 AM UTC · Completed 7:23 AM UTC
Commit: b776cf6 · View workflow run →

[mysticgohan1]

/fs-triage

[fullsend-ai-triage]

Triage Summary

Severity: High · Category: Bug

The fix agent's bot-detection regex only matches the [bot] suffix format from webhook payloads, but the eligibility check re-fetches the PR author via gh pr view --json author (GraphQL API), which returns the app/ prefix format instead. This causes all bot-authored PRs to be misclassified as human-authored, blocking auto-fix execution.

Root Cause

GitHub uses two different login formats for bot accounts depending on the API surface:

• Webhook / REST: fullsend-ai-coder[bot] → matches \[bot\]$ ✅
• GraphQL (gh pr view): app/fullsend-ai-coder → does not match \[bot\]$ ❌

Affected Locations

1. .github/workflows/reusable-fix.yml (lines 314-315)
2. .github/workflows/reusable-dispatch.yml (lines 1050-1051)
3. .fullsend/.github/workflows/dispatch.yml

Recommended Fix

Extend the bot detection to also match the app/ prefix format. PR #549 already applied this exact pattern for the pre-code.sh guard — follow that precedent:

if [[ ! "${PR_AUTHOR}" =~ \[bot\]$ ]] && [[ ! "${PR_AUTHOR}" =~ ^app/ ]]; then

Proposed Test

# Verify both bot login formats are detected
for author in 'fullsend-ai-coder[bot]' 'app/fullsend-ai-coder'; do
  # Should be classified as bot-authored (eligible for auto-fix)
  assert_bot_detected "$author"
done

# Verify human logins are not falsely detected as bots
for author in 'human-user' 'not-a-bot'; do
  assert_human_detected "$author"
done

Related

• PR fix(#545): fix existing-PR guard bot exclusion and overbroad search #549 / Issue dispatch.yml "Check for existing PRs" guard blocks /fs-code forever due to bot-login format mismatch + overbroad mention search #545 — same app/ vs [bot] mismatch fixed in pre-code.sh

---

Labels: This is a confirmed bug in the dispatch/fix workflow component with clear evidence and root cause. High priority because it silently breaks auto-fix for all bot-authored PRs.

[fullsend-ai-coder]

🤖 Finished Code · ❌ Failure · Started 7:24 AM UTC · Completed 7:33 AM UTC
Commit: b776cf6 · View workflow run →

[mysticgohan1]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ❌ Failure · Started 7:38 AM UTC · Completed 7:47 AM UTC
Commit: b776cf6 · View workflow run →

[mysticgohan1]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ❌ Failure · Started 8:11 AM UTC · Completed 8:19 AM UTC
Commit: b776cf6 · View workflow run →

[guyoron1]

Run A (baseline) complete. Artifacts archived.