Post-code script should apply ready-for-review label before validation gates to ensure review dispatch on successful PR creation

[guyoron1]

What happened

On PR #3448, the code agent (workflow run 28904209250) created a correct PR at 22:57 UTC on July 7 but the overall run was marked as failure (the 'Run code agent' step failed). Because the run failed, the post-code.sh script never reached line 541-544 where the ready-for-review label is applied. The PR timeline API confirms no label events occurred on PR fullsend-ai#3448.

Without the ready-for-review label, the review agent was never dispatched. The dispatch.yml routing for pull_request_target.opened requires is_event_actor_authorized(PR_USER_LOGIN), which fails for the coder bot account (GitHub App bots have no collaborator role). The label-based dispatch path (issues.labeled with ready-for-review) is the designed workaround, but it was never triggered.

The PR sat for ~59 hours with no automated review, receiving only a human approval from rh-hemartin on July 10 before merge.

For comparison, PR #3868 (a successful coder run) did receive the ready-for-review label at 12:34 UTC on July 9. However, even that PR showed no review agent comment, suggesting there may be a second issue in the dispatch chain beyond label application.

What could go better

The ready-for-review label application is at the very end of post-code.sh (line 541-544), after PR creation, after all validation steps. When the code agent fails for any reason after creating the PR, the label is never applied and the review agent is never dispatched. This creates an ironic gap: PRs from failed code agent runs — the ones most likely to need automated review — are the ones that don't get it.

Confidence: high that the label was not applied on PR fullsend-ai#3448 (confirmed via GitHub timeline API). High confidence that this prevented review dispatch via the issues.labeled path. Medium overall confidence because PR fullsend-ai#3868 got the label but still had no review agent activity, suggesting a possible second issue. Related to issue fullsend-ai#2908 (harness failure reporting).

Proposed change

In internal/scaffold/fullsend-repo/scripts/post-code.sh, move the ready-for-review label application (currently lines 535-544) to immediately after successful PR creation (after line 533 echo "PR created: ${PR_URL}"). The label should be applied as soon as the PR exists, regardless of what happens in subsequent validation steps.

Alternatively, add a trap or cleanup handler in the code agent harness (harness/code.yaml) that applies the label if a PR URL was captured, ensuring it runs even on failure. The post-code.sh comment at line 536-538 already documents why the label workaround exists — extend that approach to be failure-resilient.

Also investigate why PR fullsend-ai#3868 received the label but still had no review agent comment — there may be a dispatch-chain issue in the .fullsend repo's workflow routing for label-triggered events.

Validation criteria

After the change: (1) Create a test scenario where the code agent creates a PR but the run fails — verify the ready-for-review label is still applied. (2) On the next coder-generated PR, verify the review agent is dispatched and posts a review comment. (3) Check that PR fullsend-ai#3868-like cases (label applied, successful run) also result in review agent activity — if not, file a separate issue for the dispatch chain bug.

---

Generated by retro agent from fullsend-ai#3448

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 2:31 PM UTC · Completed 2:34 PM UTC
Commit: 2290266 · View workflow run →

[guyoron1]

/fs-triage

[fullsend-ai-triage]

Triage Summary

Severity: High · Category: Bug

Problem

The ready-for-review label is applied at the tail end of post-code.sh (lines 535-544), after all validation gates. When the code agent creates a PR but the run subsequently fails, the script never reaches the label application step. Since the label-based dispatch path (issues.labeled with ready-for-review) is the designed mechanism for triggering the review agent on bot PRs, these PRs silently receive no automated review.

The evidence is clear: PR fullsend-ai#3448 in the upstream repo was created at 22:57 UTC on July 7 but never received the label (confirmed via the timeline API). The PR sat for ~59 hours with no review agent activity.

Root Cause

Label application is sequenced too late in post-code.sh. The label should be applied as soon as the PR exists, not after all validation completes. The alternative dispatch path (pull_request_target.opened) cannot compensate because the coder bot account fails the is_event_actor_authorized() check.

Recommended Fix

Move the label application block to immediately after PR creation, before validation gates. Alternatively, add a trap handler that applies the label if PR_URL is set, ensuring it runs even on script failure.

Proposed Test

# Test: label applied despite post-validation failure
# Setup: mock gh CLI, simulate PR creation success + validation failure
# Assert: gh label call occurs immediately after PR creation echo
# Assert: label application is not gated on validation step exit code
# Assert: normal (successful) runs still apply the label

Related Issues

• Post-code script should create missing workflow labels on-the-fly instead of silently warning #657 covers a complementary failure mode: the label doesn't exist in the target repo. Both fixes strengthen the label application path independently.
• The secondary observation (PR docs(#3861): fix documentation nav inconsistencies fullsend-ai/fullsend#3868 received the label but had no review agent comment) may indicate a separate dispatch-chain issue — the reporter correctly suggests filing that separately if confirmed.

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 2:35 PM UTC · Completed 2:37 PM UTC
Commit: 2290266 · View workflow run →

[guyoron1]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 2:48 PM UTC · Completed 2:50 PM UTC
Commit: 2290266 · View workflow run →

[guyoron1]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 3:46 AM UTC · Completed 4:00 AM UTC
Commit: c06a60d · View workflow run →