Per QA round 2 (PR #36, finding R2-2): When --skip-context-mode is combined with --skip-mcp-check, the detect_context_mode function is never reached (because check_mcp_availability returns early on SKIP_MCP_CHECK=true). This means:
Both are plausibly intentional ("skip MCP preflight entirely"), but the rationale for Fix #3 ("surface the hidden state so users know webfetch-nudge will keep blocking") is defeated under this flag combination.
Fix options:
- Move
SKIP_CONTEXT_MODE handling (info line + cache rm) outside check_mcp_availability so it always runs regardless of --skip-mcp-check.
- Document the flag interaction in
--help so users know to pass --skip-context-mode alone when they want the info line.
Context: #36 (comment)
Per QA round 2 (PR #36, finding R2-2): When
--skip-context-modeis combined with--skip-mcp-check, thedetect_context_modefunction is never reached (becausecheck_mcp_availabilityreturns early onSKIP_MCP_CHECK=true). This means:[info] --skip-context-mode set; existing context-mode entry in .mcp.json preservedline (added in PR feat: WebFetch nudge hook + context-mode default in setup.sh (phase 44) #36) is silently suppressed./tmp/ctx-webfetch-avail-*cache invalidation is also silently skipped.Both are plausibly intentional ("skip MCP preflight entirely"), but the rationale for Fix #3 ("surface the hidden state so users know webfetch-nudge will keep blocking") is defeated under this flag combination.
Fix options:
SKIP_CONTEXT_MODEhandling (info line + cache rm) outsidecheck_mcp_availabilityso it always runs regardless of--skip-mcp-check.--helpso users know to pass--skip-context-modealone when they want the info line.Context: #36 (comment)