From 585774b5bfb5d44778f76255201aed74ee5285f1 Mon Sep 17 00:00:00 2001 From: Timothy Markfeld Date: Fri, 4 Sep 2026 17:05:23 -0400 Subject: [PATCH 1/2] feat: consolidate check for updates and center code in diff --- src/chrome/ProjectRail.tsx | 11 +------ src/chrome/Sidebar.tsx | 12 +------ src/chrome/SidebarUpdate.tsx | 56 ++++++++++++++++++-------------- src/surfaces/UnifiedDiffView.tsx | 23 ++++++++----- 4 files changed, 48 insertions(+), 54 deletions(-) diff --git a/src/chrome/ProjectRail.tsx b/src/chrome/ProjectRail.tsx index 1fe7f6b1..29abd6ce 100644 --- a/src/chrome/ProjectRail.tsx +++ b/src/chrome/ProjectRail.tsx @@ -12,7 +12,6 @@ import { File, Plus, Search, - Settings, Trash2, } from "./icons"; import { useEffect, useMemo, useRef, useState, type MouseEvent } from "react"; @@ -471,16 +470,8 @@ export function ProjectRail({ update={updateNotice} onOpenWhatsNew={onOpenWhatsNew} onDismissUpdate={onDismissUpdate} + onOpenSettings={onOpenSettings} /> -
- -
)} {projectMenu ? ( diff --git a/src/chrome/Sidebar.tsx b/src/chrome/Sidebar.tsx index a9841105..331cf37c 100644 --- a/src/chrome/Sidebar.tsx +++ b/src/chrome/Sidebar.tsx @@ -10,7 +10,6 @@ import { Pin, Plus, Search, - Settings, StickyNote, } from "./icons"; import { @@ -111,7 +110,6 @@ import { ExplorerMenu, type ExplorerMenuItem } from "./ExplorerMenu"; import { FileTree } from "./FileTree"; import { HarnessIcon } from "./HarnessIcon"; import { ProjectRail } from "./ProjectRail"; -import { RailAction } from "./RailAction"; import { TerminalSpinner } from "./TerminalSpinner"; import { DevModeSlot, IconButton, TabVisitNav } from "./TitleBar"; import { ProjectSearch } from "./ProjectSearch"; @@ -1257,16 +1255,8 @@ function SidebarComponent({ update={updateNotice} onOpenWhatsNew={onOpenWhatsNew} onDismissUpdate={onDismissUpdate} + onOpenSettings={onOpenSettings} /> -
- -
) : null} diff --git a/src/chrome/SidebarUpdate.tsx b/src/chrome/SidebarUpdate.tsx index 02fe933f..134e641b 100644 --- a/src/chrome/SidebarUpdate.tsx +++ b/src/chrome/SidebarUpdate.tsx @@ -1,4 +1,4 @@ -import { ArrowDownCircle, Loader, RefreshCw } from "./icons"; +import { ArrowDownCircle, Loader, RefreshCw, Settings } from "./icons"; import { useCallback, useEffect, useState } from "react"; import { installPendingUpdate, @@ -8,16 +8,20 @@ import { type UpdaterSnapshot, } from "../lib/updater"; import type { InstalledUpdate } from "../lib/updateNotice"; +import { MOD } from "../lib/platform"; +import { RailAction } from "./RailAction"; import { UpdateRailCard } from "./UpdateRailCard"; export function SidebarUpdateFooter({ update, onOpenWhatsNew, onDismissUpdate, + onOpenSettings, }: { update?: InstalledUpdate | null; onOpenWhatsNew?: (version: string) => void; onDismissUpdate?: () => void; + onOpenSettings?: () => void; }) { return (
@@ -28,7 +32,16 @@ export function SidebarUpdateFooter({ onDismiss={onDismissUpdate} /> ) : null} - +
+ + +
); } @@ -93,39 +106,32 @@ export function SidebarUpdate() { ? `Downloading${snapshot.progress != null ? ` ${snapshot.progress}%` : "…"}` : "Checking…" : "Check for updates"; + const title = `${label} · v${snapshot.currentVersion}`; return ( ); } diff --git a/src/surfaces/UnifiedDiffView.tsx b/src/surfaces/UnifiedDiffView.tsx index 5b1a6e68..3300c10c 100644 --- a/src/surfaces/UnifiedDiffView.tsx +++ b/src/surfaces/UnifiedDiffView.tsx @@ -894,9 +894,12 @@ const DiffLineRow = memo(function DiffLineRow({ }) { if (line.kind === "hunk") { return ( -
+
{lane === "code" ? ( - + {line.text} ) : null} @@ -920,15 +923,17 @@ const DiffLineRow = memo(function DiffLineRow({ if (lane === "gutter") { return ( -
+
{gutterTint ? ( ) : null} {number ?? ""} @@ -967,12 +972,14 @@ const DiffLineRow = memo(function DiffLineRow({ } return ( -
+
{renderLineText(line, tokens)} From 59927533feadd709fb262fd2f82ed8c1c6031919 Mon Sep 17 00:00:00 2001 From: Timothy Markfeld Date: Sat, 5 Sep 2026 09:00:36 -0400 Subject: [PATCH 2/2] revert sidebar change --- src/chrome/ProjectRail.tsx | 11 ++++++- src/chrome/Sidebar.tsx | 12 +++++++- src/chrome/SidebarUpdate.tsx | 56 ++++++++++++++++-------------------- 3 files changed, 46 insertions(+), 33 deletions(-) diff --git a/src/chrome/ProjectRail.tsx b/src/chrome/ProjectRail.tsx index 29abd6ce..1fe7f6b1 100644 --- a/src/chrome/ProjectRail.tsx +++ b/src/chrome/ProjectRail.tsx @@ -12,6 +12,7 @@ import { File, Plus, Search, + Settings, Trash2, } from "./icons"; import { useEffect, useMemo, useRef, useState, type MouseEvent } from "react"; @@ -470,8 +471,16 @@ export function ProjectRail({ update={updateNotice} onOpenWhatsNew={onOpenWhatsNew} onDismissUpdate={onDismissUpdate} - onOpenSettings={onOpenSettings} /> +
+ +
)} {projectMenu ? ( diff --git a/src/chrome/Sidebar.tsx b/src/chrome/Sidebar.tsx index 331cf37c..a9841105 100644 --- a/src/chrome/Sidebar.tsx +++ b/src/chrome/Sidebar.tsx @@ -10,6 +10,7 @@ import { Pin, Plus, Search, + Settings, StickyNote, } from "./icons"; import { @@ -110,6 +111,7 @@ import { ExplorerMenu, type ExplorerMenuItem } from "./ExplorerMenu"; import { FileTree } from "./FileTree"; import { HarnessIcon } from "./HarnessIcon"; import { ProjectRail } from "./ProjectRail"; +import { RailAction } from "./RailAction"; import { TerminalSpinner } from "./TerminalSpinner"; import { DevModeSlot, IconButton, TabVisitNav } from "./TitleBar"; import { ProjectSearch } from "./ProjectSearch"; @@ -1255,8 +1257,16 @@ function SidebarComponent({ update={updateNotice} onOpenWhatsNew={onOpenWhatsNew} onDismissUpdate={onDismissUpdate} - onOpenSettings={onOpenSettings} /> +
+ +
) : null} diff --git a/src/chrome/SidebarUpdate.tsx b/src/chrome/SidebarUpdate.tsx index 134e641b..02fe933f 100644 --- a/src/chrome/SidebarUpdate.tsx +++ b/src/chrome/SidebarUpdate.tsx @@ -1,4 +1,4 @@ -import { ArrowDownCircle, Loader, RefreshCw, Settings } from "./icons"; +import { ArrowDownCircle, Loader, RefreshCw } from "./icons"; import { useCallback, useEffect, useState } from "react"; import { installPendingUpdate, @@ -8,20 +8,16 @@ import { type UpdaterSnapshot, } from "../lib/updater"; import type { InstalledUpdate } from "../lib/updateNotice"; -import { MOD } from "../lib/platform"; -import { RailAction } from "./RailAction"; import { UpdateRailCard } from "./UpdateRailCard"; export function SidebarUpdateFooter({ update, onOpenWhatsNew, onDismissUpdate, - onOpenSettings, }: { update?: InstalledUpdate | null; onOpenWhatsNew?: (version: string) => void; onDismissUpdate?: () => void; - onOpenSettings?: () => void; }) { return (
@@ -32,16 +28,7 @@ export function SidebarUpdateFooter({ onDismiss={onDismissUpdate} /> ) : null} -
- - -
+
); } @@ -106,32 +93,39 @@ export function SidebarUpdate() { ? `Downloading${snapshot.progress != null ? ` ${snapshot.progress}%` : "…"}` : "Checking…" : "Check for updates"; - const title = `${label} · v${snapshot.currentVersion}`; return ( ); }