Skip to content

x-partial warnings with GHC 9.8 #81

@andreasabel

Description

@andreasabel

The blessings of the new x-partial warning will be bestowed unto you by GHC 9.8:

Network/URI.hs:1131:12: warning: [GHC-63394] [-Wx-partial]
    In the use of ‘head’
    (imported from Prelude, but defined in GHC.List):
    "This is a partial function, it throws an error on empty lists. Use pattern matching or Data.List.uncons instead. Consider refactoring to use Data.List.NonEmpty."
     |
1131 |         if head (uriPath ref) == '/' then
     |            ^^^^

Network/URI.hs:1437:16: warning: [GHC-63394] [-Wx-partial]
    In the use of ‘tail’
    (imported from Prelude, but defined in GHC.List):
    "This is a partial function, it throws an error on empty lists. Replace it with drop 1, or use pattern matching or Data.List.uncons instead. Consider refactoring to use Data.List.NonEmpty."
     |
1437 | query = orNull tail . uriQuery
     |                ^^^^

Network/URI.hs:1441:19: warning: [GHC-63394] [-Wx-partial]
    In the use of ‘tail’
    (imported from Prelude, but defined in GHC.List):
    "This is a partial function, it throws an error on empty lists. Replace it with drop 1, or use pattern matching or Data.List.uncons instead. Consider refactoring to use Data.List.NonEmpty."
     |
1441 | fragment = orNull tail . uriFragment
     |                   ^^^^

These are all false alarms:

network-uri/Network/URI.hs

Lines 1148 to 1149 in 4012e57

| isDefined ( uriPath ref ) =
if head (uriPath ref) == '/' then

network-uri/Network/URI.hs

Lines 1453 to 1463 in 4012e57

{-# DEPRECATED query "use uriQuery, and note changed functionality" #-}
query :: URI -> String
query = orNull tail . uriQuery
{-# DEPRECATED fragment "use uriFragment, and note changed functionality" #-}
fragment :: URI -> String
fragment = orNull tail . uriFragment
orNull :: ([a]->[a]) -> [a] -> [a]
orNull _ [] = []
orNull f as = f as

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions