Remove RepoIdentifier

Author: ericmj

lib/hex/application.ex

@@ -49,7 +49,6 @@ defmodule Hex.Application do
     defp children do
       [
         Hex.Netrc.Cache,
-        Hex.RepoIdentifier,
         Hex.State,
         Hex.Server,
         {Hex.Parallel, [:hex_fetcher]}
@@ -59,7 +58,6 @@ defmodule Hex.Application do
     defp children do
       [
         Hex.Netrc.Cache,
-        Hex.RepoIdentifier,
         Hex.State,
         Hex.Server,
         {Hex.Parallel, [:hex_fetcher]},

lib/hex/http.ex

@@ -38,10 +38,7 @@ defmodule Hex.HTTP do
 
     Hex.Shell.debug("Hex.HTTP.request(#{inspect(method)}, #{inspect(url)})")
 
-    headers =
-      headers
-      |> add_basic_auth_via_netrc(url)
-      |> add_repo_identifier_header()
+    headers = add_basic_auth_via_netrc(headers, url)
 
     timeout =
       adapter_config[:timeout] ||
@@ -316,13 +313,6 @@ defmodule Hex.HTTP do
     host
   end
 
-  defp add_repo_identifier_header(headers) do
-    case Hex.RepoIdentifier.fetch() do
-      nil -> headers
-      identifier -> Map.put(headers, "x-hex-repo-id", identifier)
-    end
-  end
-
   def handle_hex_message(nil) do
     :ok
   end

lib/hex/repo_identifier.ex

@@ -112,12 +112,6 @@ defmodule Hex.State do
       default: nil,
       config: [:cacerts_path]
     },
-    no_repo_identifier: %{
-      env: ["HEX_NO_REPO_IDENTIFIER"],
-      default: false,
-      config: [:no_repo_identifier],
-      fun: {__MODULE__, :to_boolean}
-    },
     no_short_urls: %{
       env: ["HEX_NO_SHORT_URLS"],
       config: [:no_short_urls],

lib/hex/state.ex

@@ -46,9 +46,6 @@ defmodule Mix.Tasks.Hex.Config do
     * `no_proxy` - A comma separated list of hostnames that will not be proxied,
       asterisks can be used as wildcards. Can be overridden by setting the
       environment variable `no_proxy` or `NO_PROXY`
-    * `no_repo_identifier` - If set to true Hex will not collect an anonymized
-      git repository identifier. Can be overridden by setting the environment
-      variable `HEX_NO_REPO_IDENTIFIER` (Default: `false`)
     * `http_concurrency` - Limits the number of concurrent HTTP requests in
       flight. Can be overridden by setting the environment variable
       `HEX_HTTP_CONCURRENCY` (Default: `8`)

lib/mix/tasks/hex.config.ex

@@ -116,25 +116,60 @@ defmodule Hex.HTTPTest do
     end)
   end
 
-  test "request includes identifier header when available", %{bypass: bypass} do
-    in_tmp(fn ->
-      # Initialize a git repository with a commit
-      System.cmd("git", ["init", "--initial-branch=main"])
-      System.cmd("git", ["config", "user.email", "test@example.com"])
-      System.cmd("git", ["config", "user.name", "Test User"])
-      File.write!("test.txt", "test content")
-      System.cmd("git", ["add", "test.txt"])
-      System.cmd("git", ["commit", "-m", "Initial commit"])
+  test "request with Expect 100-continue receives body after 100 response", %{bypass: bypass} do
+    # Test that httpc handles 100-continue flow correctly
+    body_content = "test request body"
 
-      Bypass.expect(bypass, fn conn ->
-        assert [client_id] = Plug.Conn.get_req_header(conn, "x-hex-repo-id")
-        assert client_id =~ ~r/^[a-f0-9]{64}$/
+    Bypass.expect(bypass, fn conn ->
+      # Verify the Expect header is present
+      assert ["100-continue"] = Plug.Conn.get_req_header(conn, "expect")
 
-        Plug.Conn.resp(conn, 200, "")
-      end)
+      # Send 100 Continue informational response
+      conn = Plug.Conn.inform(conn, 100, [])
 
-      Hex.RepoIdentifier.clear()
-      Hex.HTTP.request(:get, "http://localhost:#{bypass.port}", %{}, nil)
+      {:ok, body, conn} = Plug.Conn.read_body(conn)
+      assert body == body_content
+
+      Plug.Conn.resp(conn, 201, "success")
     end)
+
+    {:ok, {status, _headers, response_body}} =
+      Hex.HTTP.request(
+        :post,
+        "http://localhost:#{bypass.port}",
+        %{"expect" => "100-continue"},
+        {"text/plain", body_content}
+      )
+
+    assert status == 201
+    assert response_body == "success"
+  end
+
+  test "request with Expect 100-continue stops sending body on error response", %{
+    bypass: bypass
+  } do
+    # Test that when server responds with error before 100, body is not sent
+    # Note: This is handled by httpc automatically - if server responds with
+    # error status instead of 100 Continue, httpc won't send the body
+
+    Bypass.expect(bypass, fn conn ->
+      # Verify the Expect header is present
+      assert ["100-continue"] = Plug.Conn.get_req_header(conn, "expect")
+
+      # Immediately respond with 401 Unauthorized without reading body
+      # httpc should NOT send the body when it receives this error
+      Plug.Conn.resp(conn, 401, "unauthorized")
+    end)
+
+    {:ok, {status, _headers, response_body}} =
+      Hex.HTTP.request(
+        :post,
+        "http://localhost:#{bypass.port}",
+        %{"expect" => "100-continue"},
+        {"text/plain", "this body should not be sent"}
+      )
+
+    assert status == 401
+    assert response_body == "unauthorized"
   end
 end