fix: GetNote/GetTag typed Input DTO 統一 + _BoundQueryExecutor TRY300 修正#142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetCommentInputは適用済みのため Note/Tag のみ対応GetNoteInput/GetTagInputを追加し、対応する UseCase・Handler・MCP を更新_BoundQueryExecutor.write()の TRY300 違反(returninsidetry)を修正Changes
note/use_case.pyGetNoteInput追加、GetNoteUseCase.execute型変更tag/use_case.pyGetTagInput追加、GetTagUseCase.execute型変更note/handler.pyGetNoteInputインポート・使用tag/handler.pyGetTagInputインポート・使用mcp.pyGetNoteInput/GetTagInputインポート・使用sqlalchemy_executor.py_BoundQueryExecutor.writeTRY300 修正tests/example/test_mcp.pyGetNoteInput使用に更新Test plan
uv run pytest— 178 tests passed, 91.32% coverageuv run mypy src/— no issuesuv run ruff check src/ tests/— no issuesuv run ruff format --check src/ tests/— no issuesCloses #109
🤖 Generated with Claude Code