Not detecting internship date period as integer and can input text or neagative values also.

[himethcodes]

When I try to input text to the internship period it works as below screenshot.

And also when I try to input a negative value to internship period it also took without showing any error as below.

[nus-pe-script]

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thanks for your feedback! We have rejected this bug, since this is clearly specified under the usage for this "my" command in our User Guide as shown below (last line):

This is an intentional choice, as our target user profile are NUS computer engineering undergraduates who can possibly finish internships in a "Industrial Attachment Semester 1" period or a "Vacation Attachment" period for example, and therefore they should be allowed to enter such input to their user profile and forcing a compulsory date-time format could be inconvenient and would not be meaningful for such users.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: I disagree with the rejection because, even if the feature is designed to allow flexible input, there should still be basic validation to prevent clearly invalid or nonsensical inputs.

For instance, if a user accidentally types a name or a random string in the internship period field—which is supposed to represent a time range—or enters a negative number, the app currently accepts it without any warning or error. This can lead to confusion and incorrect records.

Even the examples provided by the team such as "Industrial Attachment Semester 1" or "Vacation Attachment" refer to specific internship periods officially recognized by NUS and agreed upon with companies. These are not arbitrary text values—they correspond to structured timelines.

Therefore, if the user has not scheduled the internship yet, a better approach would be to allow only a specific label like "Not scheduled yet", instead of accepting any free-form text or invalid values.

Allowing negative numbers or unrelated text undermines the data integrity of the app. A basic level of validation would improve the user experience, especially since users might enter data in a hurry.

---

❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Medium]

• I disagree

Reason for disagreement: This issue should be Medium severity, not VeryLow. Accepting invalid inputs (like negative values or irrelevant text) can lead to inaccurate records and user confusion.

If an internship period is shown as -100 or @random, it reduces the credibility of the app and can cause problems when reviewing or exporting data later.

Hence, this issue affects data correctness and user experience, and should be considered severity.Medium.

---