Skip to content

fix(protocol): carry approval id in push notifications#23

Merged
hishamkaram merged 1 commit into
mainfrom
fix/ios-pending-approval-replay
May 20, 2026
Merged

fix(protocol): carry approval id in push notifications#23
hishamkaram merged 1 commit into
mainfrom
fix/ios-pending-approval-replay

Conversation

@hishamkaram
Copy link
Copy Markdown
Owner

Summary

  • add optional approval_id to PushNotifyPayload
  • keep legacy push notification payloads backward compatible
  • cover JSON roundtrip and legacy decode behavior

Tests

  • go test ./... -run 'TestPushNotifyPayloadCarriesApprovalID|TestPushNotifyPayloadBackwardCompatible|TestPushNotifyPayloadRoundtrip' -count=1
  • go test ./... -count=1

@hishamkaram hishamkaram merged commit d4e43fe into main May 20, 2026
1 check passed
@hishamkaram hishamkaram deleted the fix/ios-pending-approval-replay branch May 20, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant