From 6ee36962fa9d2d61d7c3e9663199c433f81f771d Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Sat, 18 Jul 2026 23:49:03 -0700 Subject: [PATCH 1/9] Update config.yaml Samba: add wsdd config option --- samba/config.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/samba/config.yaml b/samba/config.yaml index 51b16cc48..21dde2e61 100644 --- a/samba/config.yaml +++ b/samba/config.yaml @@ -1,5 +1,5 @@ --- -version: 12.8.1 +version: 12.9.0 slug: samba name: Samba share description: Expose Home Assistant folders with SMB/CIFS @@ -35,6 +35,7 @@ options: apple_compatibility_mode: true netbios: true local_master: true + wsdd: true server_signing: "default" veto_files: - ._* @@ -59,6 +60,7 @@ schema: apple_compatibility_mode: bool netbios: bool local_master: bool + wsdd: bool server_signing: list(default|auto|mandatory|disabled) veto_files: - str From c30b7c29d7dcd97fd5016630ea905872a2f40b5c Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Sat, 18 Jul 2026 23:51:20 -0700 Subject: [PATCH 2/9] Update CHANGELOG.md Samba: add changelog entry for 12.9.0 --- samba/CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/samba/CHANGELOG.md b/samba/CHANGELOG.md index 670d21482..111b12f53 100644 --- a/samba/CHANGELOG.md +++ b/samba/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## 12.9.0 + +- Add configuration option to disable WSDD. When disabled, the wsdd service is + not started and the host is no longer advertised for automatic discovery. + Shares remain reachable by hostname or IP address. + ## 12.8.1 - Normalize stored `enabled_shares` values to lower case at startup. Values From 244ea036836c303c9ee508e8586056e0677211fd Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Sat, 18 Jul 2026 23:52:45 -0700 Subject: [PATCH 3/9] Update DOCS.md Samba: document wsdd option --- samba/DOCS.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/samba/DOCS.md b/samba/DOCS.md index 7947d44e2..b716db643 100644 --- a/samba/DOCS.md +++ b/samba/DOCS.md @@ -50,6 +50,7 @@ compatibility_mode: false apple_compatibility_mode: true netbios: true local_master: true +wsdd: true server_signing: "default" veto_files: - ._* @@ -121,6 +122,17 @@ When NetBIOS is enabled, try and become a local master browser on a subnet. Defaults to `true`. +### Option: `wsdd` + +Advertise the host on the network using Web Services Dynamic Discovery, so it +appears automatically under Network in Windows File Explorer. Disable this if +you connect to the shares by hostname or IP address and do not want the host +to announce itself on the network. + +Disabling this has no effect on share availability; only on discovery. + +Defaults to `true`. + ### Option: `server_signing` Configure the SMB server signing requirement. This option can improve security by requiring message signing, which helps prevent man-in-the-middle attacks. From 108ecac26e737275aedd5335e223436f785ce859 Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Sat, 18 Jul 2026 23:53:20 -0700 Subject: [PATCH 4/9] Update enable-check.sh Samba: gate wsdd service behind config option --- samba/rootfs/etc/s6-overlay/scripts/enable-check.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh b/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh index 4643c916e..b896e5753 100755 --- a/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh +++ b/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh @@ -1,7 +1,7 @@ #!/command/with-contenv bashio # shellcheck shell=bash # ============================================================================== -# Enable/disable nmbd service per config +# Enable/disable optional services per config # ============================================================================== if bashio::config.true 'netbios'; then touch /etc/s6-overlay/s6-rc.d/user/contents.d/nmbd @@ -10,3 +10,11 @@ else rm -f /etc/s6-overlay/s6-rc.d/user/contents.d/nmbd bashio::log.info "Service nmbd disabled" fi + +if bashio::config.true 'wsdd'; then + touch /etc/s6-overlay/s6-rc.d/user/contents.d/wsdd + bashio::log.info "Service wsdd enabled" +else + rm -f /etc/s6-overlay/s6-rc.d/user/contents.d/wsdd + bashio::log.info "Service wsdd disabled" +fi From e0531ef8156dbf6ff8bd4745e904c0e53b26012b Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Sat, 18 Jul 2026 23:54:11 -0700 Subject: [PATCH 5/9] Update en.yaml Samba: add UI strings for wsdd option --- samba/translations/en.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/samba/translations/en.yaml b/samba/translations/en.yaml index 43ba9a80d..68f8e9a1a 100644 --- a/samba/translations/en.yaml +++ b/samba/translations/en.yaml @@ -41,6 +41,13 @@ configuration: description: >- When NetBIOS is enabled, try and become a local master browser on a subnet. + wsdd: + name: Enable network discovery (WSDD) + description: >- + Advertise the host with Web Services Dynamic Discovery so it appears + automatically under Network in Windows File Explorer. Disable if you + connect by hostname or IP address and do not want the host to announce + itself on the network. Shares stay reachable either way. server_signing: name: Server signing description: >- From 665cdd9732ba242c6d410c36a4764348add830b0 Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:01:16 -0700 Subject: [PATCH 6/9] Update samba/translations/en.yaml Co-authored-by: Stefan Agner --- samba/translations/en.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samba/translations/en.yaml b/samba/translations/en.yaml index 68f8e9a1a..73a6a0eb4 100644 --- a/samba/translations/en.yaml +++ b/samba/translations/en.yaml @@ -41,8 +41,8 @@ configuration: description: >- When NetBIOS is enabled, try and become a local master browser on a subnet. - wsdd: - name: Enable network discovery (WSDD) + network_discovery: + name: Enable network discovery description: >- Advertise the host with Web Services Dynamic Discovery so it appears automatically under Network in Windows File Explorer. Disable if you From e30c9ae554899e5d4d31788a432a52a1a2825a4b Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:06:04 -0700 Subject: [PATCH 7/9] Update config.yaml samba: rename option to network_discovery --- samba/config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samba/config.yaml b/samba/config.yaml index 21dde2e61..5b641f332 100644 --- a/samba/config.yaml +++ b/samba/config.yaml @@ -35,7 +35,7 @@ options: apple_compatibility_mode: true netbios: true local_master: true - wsdd: true + network_discovery: true server_signing: "default" veto_files: - ._* @@ -60,7 +60,7 @@ schema: apple_compatibility_mode: bool netbios: bool local_master: bool - wsdd: bool + network_discovery: bool server_signing: list(default|auto|mandatory|disabled) veto_files: - str From 3af7b9f88a5f237391651e03e98c00cf8a4494fc Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:07:03 -0700 Subject: [PATCH 8/9] Update enable-check.sh samba: gate service on network_discovery --- samba/rootfs/etc/s6-overlay/scripts/enable-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh b/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh index b896e5753..555be3b2a 100755 --- a/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh +++ b/samba/rootfs/etc/s6-overlay/scripts/enable-check.sh @@ -11,7 +11,7 @@ else bashio::log.info "Service nmbd disabled" fi -if bashio::config.true 'wsdd'; then +if bashio::config.true 'network_discovery'; then touch /etc/s6-overlay/s6-rc.d/user/contents.d/wsdd bashio::log.info "Service wsdd enabled" else From 83226bf710d74d3bf1b10bce2bbbd13b2834a886 Mon Sep 17 00:00:00 2001 From: clowncracker <49218426+clowncracker@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:08:08 -0700 Subject: [PATCH 9/9] Update DOCS.md samba: update docs for network_discovery --- samba/DOCS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samba/DOCS.md b/samba/DOCS.md index b716db643..12a67c804 100644 --- a/samba/DOCS.md +++ b/samba/DOCS.md @@ -50,7 +50,7 @@ compatibility_mode: false apple_compatibility_mode: true netbios: true local_master: true -wsdd: true +network_discovery: true server_signing: "default" veto_files: - ._* @@ -122,7 +122,7 @@ When NetBIOS is enabled, try and become a local master browser on a subnet. Defaults to `true`. -### Option: `wsdd` +### Option: `network_discovery` Advertise the host on the network using Web Services Dynamic Discovery, so it appears automatically under Network in Windows File Explorer. Disable this if