Extra spaces being added

[rightaway]

var htmlToText = require('html-to-text');
var text = htmlToText.fromString("This is a <a href='url'>link</a>.");
console.log(text);

will print This is a link [url] . (note the space before the period). Makes it problematic to use, for example when a url comes at the end of a sentence.

It also seems to be adding spaces before the link.

[mlegenhausen]

This is a known bug I would be happy about a pull request.

[rightaway]

I can do it, but I have a question. The part causing the issue is https://github.com/werk85/node-html-to-text/blob/929dfa69a18f2d0fe9cb4d4424ac039108d54246/lib/html-to-text.js#L119.

case 'a':
    // Inline element needs a leading space if `result` currently
    // doesn't end with whitespace
    elem.needsSpace = whiteSpaceRegex.test(result);
    result += format.anchor(elem, walk, options);
    break;

elem.needsSpace is getting set to true because of this rule that inline elements need leading spaces is if doesn't end with whitespace. Why is that? I can't think of an example where the whitespace should be added rather than just using what is already around it. Can elem.needsSpace always be false for a tags?

[mlegenhausen]

Don't know exactly anymore why. But feel free to change some logic, if you can provide some unit tests so I can see that the changes only effect the trailing space.

For more details about the space problem you can take a look at #21 and #48. The last one also provides some failing unit tests for the links, that I removed because of not having a solution for it.

[rightaway]

I tried various things on this the last couple of days to fix it but I'm afraid I don't understand this code well enough, I just introduced new errors in my efforts. Perhaps @danmactough who did #21 could take a look? I think it's an important enough issue as (at least for us) we can't use it in production to send for example text emails made from html with the current formatting.