Broaden request-error fallback typing and invalid URL coverage

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -135,7 +135,7 @@ def extract_request_error_context(error: httpx.RequestError) -> tuple[str, str]:
 
 
 def format_request_failure_message(
-    error: httpx.RequestError, *, fallback_method: str, fallback_url: str
+    error: httpx.RequestError, *, fallback_method: object, fallback_url: object
 ) -> str:
     request_method, request_url = extract_request_error_context(error)
     effective_method = (

tests/test_transport_error_utils.py

@@ -235,6 +235,16 @@ def test_format_request_failure_message_rejects_overlong_fallback_methods():
     assert message == "Request UNKNOWN https://example.com/fallback failed"
 
 
+def test_format_request_failure_message_normalizes_non_string_fallback_values():
+    message = format_request_failure_message(
+        httpx.RequestError("network down"),
+        fallback_method=123,
+        fallback_url=object(),
+    )
+
+    assert message == "Request UNKNOWN unknown URL failed"
+
+
 def test_format_generic_request_failure_message_normalizes_invalid_url_objects():
     message = format_generic_request_failure_message(
         method="GET",

tests/test_transport_response_handling.py

@@ -408,6 +408,22 @@ def failing_get(*args, **kwargs):
         transport.close()
 
 
+def test_sync_transport_request_error_without_request_uses_unknown_url_for_invalid_input():
+    transport = SyncTransport(api_key="test-key")
+    original_get = transport.client.get
+
+    def failing_get(*args, **kwargs):
+        raise httpx.RequestError("network down")
+
+    transport.client.get = failing_get  # type: ignore[assignment]
+    try:
+        with pytest.raises(HyperbrowserError, match="Request GET unknown URL failed"):
+            transport.get(None)  # type: ignore[arg-type]
+    finally:
+        transport.client.get = original_get  # type: ignore[assignment]
+        transport.close()
+
+
 def test_async_transport_request_error_without_request_uses_fallback_url():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")
@@ -428,3 +444,24 @@ async def failing_delete(*args, **kwargs):
             await transport.close()
 
     asyncio.run(run())
+
+
+def test_async_transport_request_error_without_request_uses_unknown_url_for_invalid_input():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        original_delete = transport.client.delete
+
+        async def failing_delete(*args, **kwargs):
+            raise httpx.RequestError("network down")
+
+        transport.client.delete = failing_delete  # type: ignore[assignment]
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Request DELETE unknown URL failed"
+            ):
+                await transport.delete(None)  # type: ignore[arg-type]
+        finally:
+            transport.client.delete = original_delete  # type: ignore[assignment]
+            await transport.close()
+
+    asyncio.run(run())