Sanitize extension missing-key display values

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -6,6 +6,7 @@
 
 _MAX_DISPLAYED_MISSING_KEYS = 20
 _MAX_DISPLAYED_MISSING_KEY_LENGTH = 120
+_TRUNCATED_KEY_DISPLAY_SUFFIX = "... (truncated)"
 
 
 def _get_type_name(value: Any) -> str:
@@ -21,12 +22,20 @@ def _safe_stringify_key(value: object) -> str:
 
 def _format_key_display(value: object) -> str:
     normalized_key = _safe_stringify_key(value)
+    normalized_key = "".join(
+        "?" if ord(character) < 32 or ord(character) == 127 else character
+        for character in normalized_key
+    ).strip()
+    if not normalized_key:
+        return "<blank key>"
     if len(normalized_key) <= _MAX_DISPLAYED_MISSING_KEY_LENGTH:
         return normalized_key
-    return (
-        f"{normalized_key[:_MAX_DISPLAYED_MISSING_KEY_LENGTH]}"
-        "... (truncated)"
+    available_key_length = _MAX_DISPLAYED_MISSING_KEY_LENGTH - len(
+        _TRUNCATED_KEY_DISPLAY_SUFFIX
     )
+    if available_key_length <= 0:
+        return _TRUNCATED_KEY_DISPLAY_SUFFIX
+    return f"{normalized_key[:available_key_length]}{_TRUNCATED_KEY_DISPLAY_SUFFIX}"
 
 
 def _summarize_mapping_keys(mapping: Mapping[object, object]) -> str:

tests/test_extension_utils.py

@@ -138,12 +138,28 @@ def test_parse_extension_list_response_data_missing_key_truncates_long_key_names
         HyperbrowserError,
         match=(
             "Expected 'extensions' key in response but got "
-            r"\[k{120}\.\.\. \(truncated\)\] keys"
+            r"\[k{105}\.\.\. \(truncated\)\] keys"
         ),
     ):
         parse_extension_list_response_data({long_key: "value"})
 
 
+def test_parse_extension_list_response_data_missing_key_normalizes_blank_key_names():
+    with pytest.raises(
+        HyperbrowserError,
+        match="Expected 'extensions' key in response but got \\[<blank key>\\] keys",
+    ):
+        parse_extension_list_response_data({"   ": "value"})
+
+
+def test_parse_extension_list_response_data_missing_key_normalizes_control_characters():
+    with pytest.raises(
+        HyperbrowserError,
+        match="Expected 'extensions' key in response but got \\[bad\\?key\\] keys",
+    ):
+        parse_extension_list_response_data({"bad\tkey": "value"})
+
+
 def test_parse_extension_list_response_data_missing_key_handles_unprintable_keys():
     class _BrokenStringKey:
         def __str__(self) -> str: