Harden web manager payload serialization paths

cursoragent · shrisukhani · cursoragent · commit fd3129f1e213 · 2026-02-14T06:00:36.000Z
Co-authored-by: Shri Sukhani &lt;shrisukhani@users.noreply.github.com&gt;
diff --git a/hyperbrowser/client/managers/async_manager/web/__init__.py b/hyperbrowser/client/managers/async_manager/web/__init__.py
@@ -1,5 +1,6 @@
 from .batch_fetch import BatchFetchManager
 from .crawl import WebCrawlManager
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     FetchParams,
     FetchResponse,
@@ -17,7 +18,17 @@ def __init__(self, client):
         self.crawl = WebCrawlManager(client)
 
     async def fetch(self, params: FetchParams) -> FetchResponse:
-        payload = params.model_dump(exclude_none=True, by_alias=True)
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web fetch params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize web fetch params")
         inject_web_output_schemas(
             payload, params.outputs.formats if params.outputs else None
         )
@@ -33,9 +44,20 @@ async def fetch(self, params: FetchParams) -> FetchResponse:
         )
 
     async def search(self, params: WebSearchParams) -> WebSearchResponse:
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web search params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize web search params")
         response = await self._client.transport.post(
             self._client._build_url("/web/search"),
-            data=params.model_dump(exclude_none=True, by_alias=True),
+            data=payload,
         )
         return parse_response_model(
             response.data,
diff --git a/hyperbrowser/client/managers/async_manager/web/batch_fetch.py b/hyperbrowser/client/managers/async_manager/web/batch_fetch.py
@@ -1,5 +1,6 @@
 from typing import Optional
 
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     StartBatchFetchJobParams,
     StartBatchFetchJobResponse,
@@ -27,7 +28,17 @@ def __init__(self, client):
     async def start(
         self, params: StartBatchFetchJobParams
     ) -> StartBatchFetchJobResponse:
-        payload = params.model_dump(exclude_none=True, by_alias=True)
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize batch fetch start params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize batch fetch start params")
         inject_web_output_schemas(
             payload, params.outputs.formats if params.outputs else None
         )
@@ -56,9 +67,20 @@ async def get(
         self, job_id: str, params: Optional[GetBatchFetchJobParams] = None
     ) -> BatchFetchJobResponse:
         params_obj = params or GetBatchFetchJobParams()
+        try:
+            query_params = params_obj.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize batch fetch get params",
+                original_error=exc,
+            ) from exc
+        if type(query_params) is not dict:
+            raise HyperbrowserError("Failed to serialize batch fetch get params")
         response = await self._client.transport.get(
             self._client._build_url(f"/web/batch-fetch/{job_id}"),
-            params=params_obj.model_dump(exclude_none=True, by_alias=True),
+            params=query_params,
         )
         return parse_response_model(
             response.data,
diff --git a/hyperbrowser/client/managers/async_manager/web/crawl.py b/hyperbrowser/client/managers/async_manager/web/crawl.py
@@ -1,5 +1,6 @@
 from typing import Optional
 
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     StartWebCrawlJobParams,
     StartWebCrawlJobResponse,
@@ -25,7 +26,17 @@ def __init__(self, client):
         self._client = client
 
     async def start(self, params: StartWebCrawlJobParams) -> StartWebCrawlJobResponse:
-        payload = params.model_dump(exclude_none=True, by_alias=True)
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web crawl start params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize web crawl start params")
         inject_web_output_schemas(
             payload, params.outputs.formats if params.outputs else None
         )
@@ -54,9 +65,20 @@ async def get(
         self, job_id: str, params: Optional[GetWebCrawlJobParams] = None
     ) -> WebCrawlJobResponse:
         params_obj = params or GetWebCrawlJobParams()
+        try:
+            query_params = params_obj.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web crawl get params",
+                original_error=exc,
+            ) from exc
+        if type(query_params) is not dict:
+            raise HyperbrowserError("Failed to serialize web crawl get params")
         response = await self._client.transport.get(
             self._client._build_url(f"/web/crawl/{job_id}"),
-            params=params_obj.model_dump(exclude_none=True, by_alias=True),
+            params=query_params,
         )
         return parse_response_model(
             response.data,
diff --git a/hyperbrowser/client/managers/sync_manager/web/__init__.py b/hyperbrowser/client/managers/sync_manager/web/__init__.py
@@ -1,5 +1,6 @@
 from .batch_fetch import BatchFetchManager
 from .crawl import WebCrawlManager
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     FetchParams,
     FetchResponse,
@@ -17,7 +18,17 @@ def __init__(self, client):
         self.crawl = WebCrawlManager(client)
 
     def fetch(self, params: FetchParams) -> FetchResponse:
-        payload = params.model_dump(exclude_none=True, by_alias=True)
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web fetch params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize web fetch params")
         inject_web_output_schemas(
             payload, params.outputs.formats if params.outputs else None
         )
@@ -33,9 +44,20 @@ def fetch(self, params: FetchParams) -> FetchResponse:
         )
 
     def search(self, params: WebSearchParams) -> WebSearchResponse:
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web search params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize web search params")
         response = self._client.transport.post(
             self._client._build_url("/web/search"),
-            data=params.model_dump(exclude_none=True, by_alias=True),
+            data=payload,
         )
         return parse_response_model(
             response.data,
diff --git a/hyperbrowser/client/managers/sync_manager/web/batch_fetch.py b/hyperbrowser/client/managers/sync_manager/web/batch_fetch.py
@@ -1,5 +1,6 @@
 from typing import Optional
 
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     StartBatchFetchJobParams,
     StartBatchFetchJobResponse,
@@ -25,7 +26,17 @@ def __init__(self, client):
         self._client = client
 
     def start(self, params: StartBatchFetchJobParams) -> StartBatchFetchJobResponse:
-        payload = params.model_dump(exclude_none=True, by_alias=True)
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize batch fetch start params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize batch fetch start params")
         inject_web_output_schemas(
             payload, params.outputs.formats if params.outputs else None
         )
@@ -54,9 +65,20 @@ def get(
         self, job_id: str, params: Optional[GetBatchFetchJobParams] = None
     ) -> BatchFetchJobResponse:
         params_obj = params or GetBatchFetchJobParams()
+        try:
+            query_params = params_obj.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize batch fetch get params",
+                original_error=exc,
+            ) from exc
+        if type(query_params) is not dict:
+            raise HyperbrowserError("Failed to serialize batch fetch get params")
         response = self._client.transport.get(
             self._client._build_url(f"/web/batch-fetch/{job_id}"),
-            params=params_obj.model_dump(exclude_none=True, by_alias=True),
+            params=query_params,
         )
         return parse_response_model(
             response.data,
diff --git a/hyperbrowser/client/managers/sync_manager/web/crawl.py b/hyperbrowser/client/managers/sync_manager/web/crawl.py
@@ -1,5 +1,6 @@
 from typing import Optional
 
+from hyperbrowser.exceptions import HyperbrowserError
 from hyperbrowser.models import (
     StartWebCrawlJobParams,
     StartWebCrawlJobResponse,
@@ -25,7 +26,17 @@ def __init__(self, client):
         self._client = client
 
     def start(self, params: StartWebCrawlJobParams) -> StartWebCrawlJobResponse:
-        payload = params.model_dump(exclude_none=True, by_alias=True)
+        try:
+            payload = params.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web crawl start params",
+                original_error=exc,
+            ) from exc
+        if type(payload) is not dict:
+            raise HyperbrowserError("Failed to serialize web crawl start params")
         inject_web_output_schemas(
             payload, params.outputs.formats if params.outputs else None
         )
@@ -54,9 +65,20 @@ def get(
         self, job_id: str, params: Optional[GetWebCrawlJobParams] = None
     ) -> WebCrawlJobResponse:
         params_obj = params or GetWebCrawlJobParams()
+        try:
+            query_params = params_obj.model_dump(exclude_none=True, by_alias=True)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to serialize web crawl get params",
+                original_error=exc,
+            ) from exc
+        if type(query_params) is not dict:
+            raise HyperbrowserError("Failed to serialize web crawl get params")
         response = self._client.transport.get(
             self._client._build_url(f"/web/crawl/{job_id}"),
-            params=params_obj.model_dump(exclude_none=True, by_alias=True),
+            params=query_params,
         )
         return parse_response_model(
             response.data,
diff --git a/tests/test_web_manager_serialization.py b/tests/test_web_manager_serialization.py
