Placeholder <version> incorrectly parses to "x to x"

[Tig3r98]

If you set the plugin to allow specific versions:

versions = [770, 768, 767, 766, 765, 764, 763, 762, 761, 760, 759, 758, 757, 755, 753, 751, 736, 735, 578, 575, 573, 498, 490, 485, 480, 477, 404, 401, 393, 340, 338, 335, 316, 315, 210, 110, 109, 108, 107, 47, 5, 4]
# Allowing: 1.16.5 (754), 1.17.1 (756), 1.21.4 (769)

the disconnect_message is wrong, parsing with:
1.16.4 to 1.21.4

This confuses users, which think they can join with any version in-between. This short format should only be presented when all in-between protocols are supported, excluding snapshots. It's probably easier to add a config option to use versions as a whitelist.

Obviously the workaround is not to use the placeholder, but it still shouldn't return wrong information.

While we're at it, the placeholder should ideally be translatable (the "to" word isn't).

[hyperdefined]

I do like the idea of swapping to a whitelist instead. For formatting the placeholder, I'm not really sure how to tackle this correctly. One ugly way is to just list every single version allowed out.

For a customized message, would have to solve the first issue above before I can setup a message that is configurable.

[Tig3r98]

After thinking about it, I'd remove the <versions> placeholder entirely, adding <latest_allowed> instead (in case of latest Velocity it would obviously parse to 1.21.5 if the protocol is not blocked).

The default config would be:
disconnect_message = "<red>You cannot connect with this version! We only allow versions 1.19.4 to <latest_allowed>." (you need to also block protocol 5 (1.7.10) in the default config, which is supported by Velocity afaik)

This way, original functionality is preserved. If a user is not supporting a long list of versions it must edit the config everytime anyway, and it can take the two seconds required to also change the error string manually. This also solves the translation problem.

Obviously it's still a very good idea to add an option to either use the list as a blacklist or as a whitelist (but do use a blacklist as default, so that you don't need to update the plugin config every release).

It would also be useful to have a placeholder that parses to a dumb list of allowed protocols, at least in whitelist mode, so that if a user has like 3 versions supported that's taken care of; in my case:
1.16.4, 1.16.5, 1.17.1, 1.21.4 (I don't know if you can handle multiple MC versions that have the same protocol, though, maybe use the newest there?)

[hyperdefined]

After thinking about it, I'd remove the <versions> placeholder entirely, adding <latest_allowed> instead (in case of latest Velocity it would obviously parse to 1.21.5 if the protocol is not blocked).

The default config would be: disconnect_message = "<red>You cannot connect with this version! We only allow versions 1.19.4 to <latest_allowed>." (you need to also block protocol 5 (1.7.10) in the default config, which is supported by Velocity afaik)

I like this idea. Maybe I add also add oldest placeholder? I can check the list of versions and make sure there are no gaps in this case.

It would also be useful to have a placeholder that parses to a dumb list of allowed protocols, at least in whitelist mode, so that if a user has like 3 versions supported that's taken care of; in my case:
1.16.4, 1.16.5, 1.17.1, 1.21.4 (I don't know if you can handle multiple MC versions that have the same protocol, though, maybe use the newest there?)

Could add a "raw list" placeholder. This one just lists out every version that you can connect with. In this case if you allow only 1.16.4, 1.16.5, 1.17.1, 1.21.4, it will print the "raw list" and display that.

Velocity does map 754 to both versions (see here: https://github.com/PaperMC/Velocity/blob/ae312339a36d9c60232a275378cf264d41d4f7c9/api/src/main/java/com/velocitypowered/api/network/ProtocolVersion.java#L77). Can display each version that share the same protocol.

[Tig3r98]

Sorry, busy weeks.

I wouldn't add oldest, that would defeat the point, as you can't simply use this:
<red>You cannot connect with this version! We only allow versions <oldest> to <latest_allowed>.
Because again you're not checking the list of versions, and in this case you actually shouldn't, as oldest must be oldest.

I think the raw list would be useful for some setups like mine and yes I think you should show all versions using a protocol..

Do remember to implement a whitelist mode, if you want.

[hyperdefined]

I think just in general, I will change the placeholder to a raw list. However, if there are gaps, it will display the ranges (like 1.8-1.17, 1.18-1.21, something like that). In your case, it will just display the versions you listed.

[hyperdefined]

I made a test plugin. It's in the zip attached. Furthermore, please delete your config file and let it remake it. Take a look at the config and test it! This should now format the versions much better and include missing ones in gaps.

Ignore the warning about missing version.

velocityblockversion-1.1.0.zip

[Tig3r98]

Nice work. I did do some testing.

754 (for example) parses to 1.16.5 instead of 1.16.4-1.16.5, is that intentional? It's probably fine, same-protocol versions should probably be used on the highest client version anyway (even 1.8 and 1.7.2 I think is fine?). It's not technically correct though. Anyway, this does not interfere with normal consecutive protocols (e.g. 753,754,755).

A couple of further suggestions:

• Default should probably be blacklist mode (and not include 770) in order to work on latest version by default.
• If no versions are supported, the placeholder parses empty. I've seen your warninr in console, but it's probably better to give an error to the client too, instead (can be hardcoded english, admins will see it and it can never be a valid config anyway). I'd not even bother parsing it to - or none.
• I'd add some newline chars, like this:
  "<red>You cannot connect with this version!\n\nSupported version(s): <versions>"
  Even the 1.7.2 client supports this.

Aside from that, all looks fine :)

[hyperdefined]

I believe it should be fine... I can try to add the extra versions that share the protocol versions so it's all correct.

1. Can do, the plugin does automatically use blacklist mode if you update the plugin and don't edit the config so it works automatically.
2. I thought I added a message for this, but I will double check it again.
3. Can do newlines :)