From 4c1c45beadd333cb0cabeea1da59fd98a28a15b7 Mon Sep 17 00:00:00 2001 From: Jose Date: Wed, 29 Apr 2026 15:52:20 +0200 Subject: [PATCH 1/2] Fail loudly on duplicate scoped identifiers in SymbolConverter --- src/ZeroC.Slice.Symbols/SymbolConverter.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ZeroC.Slice.Symbols/SymbolConverter.cs b/src/ZeroC.Slice.Symbols/SymbolConverter.cs index 4577e5d339..3929f66749 100644 --- a/src/ZeroC.Slice.Symbols/SymbolConverter.cs +++ b/src/ZeroC.Slice.Symbols/SymbolConverter.cs @@ -54,7 +54,8 @@ private SymbolConverter(IEnumerable allFiles) { if (GetNamedIdentifier(symbol) is string id) { - _named.TryAdd($"{moduleScope}::{id}", (file, symbol)); + // Scoped IDs are warned to be unique by the compiler, we can safely use them as dictionary keys. + _named.Add($"{moduleScope}::{id}", (file, symbol)); } } } From ed225af7ecf3102195032e126de04bc42b980f7a Mon Sep 17 00:00:00 2001 From: Jose Date: Wed, 29 Apr 2026 17:15:08 +0200 Subject: [PATCH 2/2] Update src/ZeroC.Slice.Symbols/SymbolConverter.cs Co-authored-by: Joe George --- src/ZeroC.Slice.Symbols/SymbolConverter.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ZeroC.Slice.Symbols/SymbolConverter.cs b/src/ZeroC.Slice.Symbols/SymbolConverter.cs index 3929f66749..d7b8610b9e 100644 --- a/src/ZeroC.Slice.Symbols/SymbolConverter.cs +++ b/src/ZeroC.Slice.Symbols/SymbolConverter.cs @@ -54,7 +54,7 @@ private SymbolConverter(IEnumerable allFiles) { if (GetNamedIdentifier(symbol) is string id) { - // Scoped IDs are warned to be unique by the compiler, we can safely use them as dictionary keys. + // Scoped IDs are guaranteed to be unique by the compiler, we can safely use them as dictionary keys. _named.Add($"{moduleScope}::{id}", (file, symbol)); } }