Commit b7ccf33
Address CI codex R1 P3s on PR-A: API doc citation + test docstring framing
P3 (API doc citation drift): docs/api/chaisemartin_dhaultfoeuille.rst:116
still cited the dynamic companion as "(2022, revised 2024)"; the R1
cross-surface sweep missed this file. Aligns to "(2022, revised July
2023)" matching docs/references.rst, docs/methodology/REGISTRY.md, both
paper-review headers, and both code docstrings.
P3 (test docstring "paper-literal" framing): The regression test
test_cell_count_weighting_unbalanced_input at
tests/test_chaisemartin_dhaultfoeuille.py:828-850 still framed equal-cell
weighting as "paper-literal" / "the correct behavior". This contradicts
the updated REGISTRY:517 note and the new paper review (L76-L88, L278-L280)
which transcribe Equation 3 of the AER 2020 paper as observation-sum
weighting and document equal-cell as the library's deviation.
Rewrites the docstring to describe equal-cell as the library's
documented contract (deviation from both the paper and R), with
explicit cross-links to REGISTRY and the paper review. Removes the
"correct behavior" language. The test's actual assertions and DGP
construction are unchanged - the test still pins the library's
equal-cell contract; only the docstring narrative is corrected.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 6d98399 commit b7ccf33
2 files changed
Lines changed: 21 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
827 | 827 | | |
828 | 828 | | |
829 | 829 | | |
830 | | - | |
831 | | - | |
832 | | - | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
833 | 839 | | |
834 | 840 | | |
835 | 841 | | |
836 | 842 | | |
837 | | - | |
| 843 | + | |
838 | 844 | | |
839 | | - | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | | - | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
844 | 850 | | |
845 | 851 | | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
850 | | - | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
851 | 857 | | |
852 | 858 | | |
853 | 859 | | |
| |||
0 commit comments