From df3d92e34a2d33bfbb939bf4304059c0534a3e38 Mon Sep 17 00:00:00 2001 From: DucNghia Date: Thu, 10 Sep 2026 07:52:01 +0700 Subject: [PATCH 1/4] feat(tasks): preview sub-agent conversations in realtime --- web/src/styles.css | 4 +- web/src/tasks/TaskTurnBubble.tsx | 80 ++++++++++++++++-- web/src/tasks/subagentPresentation.ts | 3 + web/src/test/subagentPopup.test.tsx | 114 ++++++++++++++++++++++++++ 4 files changed, 193 insertions(+), 8 deletions(-) create mode 100644 web/src/test/subagentPopup.test.tsx diff --git a/web/src/styles.css b/web/src/styles.css index d6bd292e..a2e90230 100644 --- a/web/src/styles.css +++ b/web/src/styles.css @@ -197,10 +197,10 @@ .turn-subagents{margin:2px 0 12px;padding:10px;border:1px solid var(--border);border-radius:12px;background:color-mix(in srgb,var(--surface) 78%,transparent)} .turn-subagents-heading{display:flex;align-items:center;gap:7px;margin-bottom:8px;color:var(--muted);font-size:.7rem}.turn-subagents-heading svg{width:15px;height:15px}.turn-subagents-heading strong{color:var(--text);font-size:.72rem}.turn-subagents-heading span{display:grid;min-width:20px;height:20px;padding:0 6px;place-items:center;border:1px solid var(--border);border-radius:999px;font-size:.62rem} -.turn-subagents-list{display:grid;gap:7px}.turn-subagent{display:grid;min-height:48px;padding:8px 10px;grid-template-columns:28px minmax(0,1fr) 18px;align-items:center;gap:9px;color:inherit;text-decoration:none;border:1px solid var(--border);border-radius:10px;background:var(--surface-2);transition:border-color .15s ease,transform .15s ease,background .15s ease}.turn-subagent[href]:hover{transform:translateY(-1px);border-color:var(--accent);background:var(--surface)} +.turn-subagents-list{display:grid;gap:7px}.turn-subagent{display:grid;min-height:48px;padding:8px 10px;grid-template-columns:28px minmax(0,1fr) 18px;align-items:center;gap:9px;color:inherit;text-decoration:none;border:1px solid var(--border);border-radius:10px;background:var(--surface-2);transition:border-color .15s ease,transform .15s ease,background .15s ease}.turn-subagent[type=button]{width:100%;font:inherit;text-align:left;cursor:pointer}.turn-subagent[type=button]:hover{transform:translateY(-1px);border-color:var(--accent);background:var(--surface)} .turn-subagent-state{display:grid;width:28px;height:28px;place-items:center;border-radius:9px;background:var(--surface);color:var(--muted)}.turn-subagent-state svg{width:15px;height:15px}.turn-subagent-state.pending,.turn-subagent-state.running{color:var(--accent)}.turn-subagent-state.completed{color:var(--good)}.turn-subagent-state.failed,.turn-subagent-state.stopped,.turn-subagent-state.timedOut,.turn-subagent-state.interrupted{color:var(--bad)} .turn-subagent-copy{display:grid;min-width:0;gap:2px}.turn-subagent-copy strong{overflow:hidden;text-overflow:ellipsis;white-space:nowrap;font-size:.72rem}.turn-subagent-copy small{color:var(--muted);font-size:.64rem}.turn-subagent.running .turn-subagent-copy small,.turn-subagent.pending .turn-subagent-copy small{color:var(--accent)}.turn-subagent.completed .turn-subagent-copy small{color:var(--good)}.turn-subagent.failed .turn-subagent-copy small,.turn-subagent.stopped .turn-subagent-copy small,.turn-subagent.timedOut .turn-subagent-copy small,.turn-subagent.interrupted .turn-subagent-copy small{color:var(--bad)}.turn-subagent-open{width:15px;height:15px;color:var(--muted)} -@media(max-width:520px){.turn-subagents{padding:8px}.turn-subagent{grid-template-columns:26px minmax(0,1fr) 16px;padding-inline:8px}} +.subagent-preview-modal{width:min(980px,calc(100vw - 32px));max-height:min(88dvh,900px);display:flex;flex-direction:column;overflow:hidden}.subagent-preview-body{min-height:180px;flex:1 1 auto;overflow:auto;padding:0 18px 18px}.subagent-preview-timeline{padding:0}.subagent-preview-state{min-height:180px;display:flex;align-items:center;justify-content:center;gap:9px;padding:24px;color:var(--muted);text-align:center}.subagent-preview-state>svg{width:18px;flex:0 0 auto}.subagent-preview-state.error{color:var(--bad);flex-wrap:wrap}.subagent-preview-actions{flex:0 0 auto;display:flex;justify-content:flex-end;padding:12px 18px 18px;border-top:1px solid var(--border)}.subagent-preview-open{min-height:44px}.subagent-preview-open svg{width:15px;height:15px}@media(max-width:520px){.turn-subagents{padding:8px}.turn-subagent{grid-template-columns:26px minmax(0,1fr) 16px;padding-inline:8px}.subagent-preview-modal{width:calc(100vw - 16px);max-height:92dvh}.subagent-preview-body{padding:0 10px 12px}.subagent-preview-actions{padding:10px 10px 12px}.subagent-preview-open{width:100%}} /* ChatGPT browser bridge */ .tasks-header-actions{display:flex;align-items:center;gap:8px}.tasks-new-message{display:inline-flex;min-height:36px;padding:7px 10px;align-items:center;gap:6px;color:var(--text);text-decoration:none;background:var(--surface-2);border:1px solid var(--border);border-radius:9px;font-size:.68rem;font-weight:700;white-space:nowrap}.tasks-new-message:hover{border-color:var(--accent);background:var(--surface-3)}.tasks-new-message svg{width:15px;height:15px;color:var(--accent)} diff --git a/web/src/tasks/TaskTurnBubble.tsx b/web/src/tasks/TaskTurnBubble.tsx index 12efe434..d68684fc 100644 --- a/web/src/tasks/TaskTurnBubble.tsx +++ b/web/src/tasks/TaskTurnBubble.tsx @@ -2,12 +2,13 @@ import { subagentLabel, subagentTreeRows } from './subagentPresentation'; import { TurnThinkingSources } from './TurnThinkingSources'; import { browserThinking, isBrowserEvent } from './chatGptThinking'; import { BookOpen, Bot, CheckCircle2, ChevronDown, CircleAlert, CircleStop, Clock3, ExternalLink, FileCode2, FilePenLine, GitBranch, LoaderCircle, MessageSquareText, Search, TerminalSquare, Wrench } from 'lucide-react'; -import { lazy, Suspense, useEffect, useLayoutEffect, useRef, useState } from 'react'; +import { lazy, Suspense, useCallback, useEffect, useLayoutEffect, useRef, useState } from 'react'; import { ChatRichText } from './rich-text/ChatRichText'; import { api } from '../api'; import { Modal } from '../components'; import { appLocale, formatAppNumber, tr } from '../i18n'; -import type { SubagentRun, TaskActivityDetail, TaskTurn, TimelineEvent } from '../types'; +import { useRealtime } from '../realtime'; +import type { SubagentRun, TaskActivityDetail, TaskDetail, TaskTurn, TimelineEvent } from '../types'; import { ApprovalDecisionActions } from './ApprovalDecisionActions'; import { CompletionQualityCard } from './CompletionQualityCard'; import { StopActivityDialog } from './StopActivityDialog'; @@ -21,7 +22,9 @@ import { activityOutput, activityInputDetails, buildProcessBlocks, + buildTaskTurns, duration, + mergeLiveDetail, eventText, findCompletionSignal, findFinalResponse, @@ -197,6 +200,7 @@ function SubagentList({ agents }: { agents: SubagentRun[] }) { } function SubagentItem({ agent }: { agent: SubagentRun }) { + const [previewOpen, setPreviewOpen] = useState(false); const pending = agent.status === 'pending'; const running = agent.status === 'running'; const failed = agent.status === 'failed'; @@ -207,11 +211,75 @@ function SubagentItem({ agent }: { agent: SubagentRun }) { const content = <> {agent.name}{statusDetail} - {agent.taskId &&