Saving settings screen with repository that does not contain embedded-git-config.json renders repository unusable

[raymond-rebbeck]

Occurs on latest main branch, git bisect suggests 347b104 is the offending commit.

I am evaluating a move from git-source-control 2.7.1 to a later version. My repository does not yet contain embedded-git-config.json

When I save the settings screen an embedded-git-config.json is generated but my Remote Repository setting is wiped and my underlying repository has .git/config modified such that it is no longer usable. Can no longer pull, fetch, switch branches, etc.

If I do the same but have an embedded-git-config.json there, the Remote Repository is not wiped and the repo is fine. My initial thoughts when this happened was that it might be related to using Microsoft Azure DevOps but seems to not be the case.

Before
Settings

.git/config

[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true
[remote "origin"]
        url = https://********@dev.azure.com/********/***********/_git/****************
        fetch = +refs/heads/*:refs/remotes/origin/*
[branch "develop"]
        remote = origin
        merge = refs/heads/develop

After
Settings:

.git/config

[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true

I notice while putting this issue together too that the username is not actually redacted, perhaps an issue with HTTPS remotes. Not enough of a concern for me to raise a separate issue for at this very moment though.

[raymond-rebbeck]

This appears to be caused by using settingsUIReadOnly=1 when this is set then %request.Data("remoteRepo" is not set in the request and so will highly likely not match ##class(SourceControl.Git.Utils).GetRedactedRemote(). Because the code in the referenced commit is moved out of an if block that checks settingsUIReadOnly then the remote is set with a blank newRemote value.

[isc-pbarton]

Fixed by #782