[Feature Request] Give user choice to view forked copy or fork again

[imranariffin]

As a user I would like to know that a notebook I'm interested to copy/fork has already already been copied/forked by me.

What I Did

Viewed a notebook, forked and edited it only to later realize that I had already forked it before.

What I Expected

If I had done some modifications on the first copy in some cases I would rather continue my work there than starting over. I would like to have a choice to either continue work on the existing fork or fork a new one.

As per discussion in PR #2550, it might be a good idea to roughly follow GitHub's forking behavior:

In our case we would probably either offer to open up existing fork(s) in a new tab or allow the user to fork again. You could probably do this with a modal element. A bit complicated but might be a fun project!

So this is the behavior that I propose:

When a user who has already forked this notebook clicks on the "Make a copy to your account" link, open a modal instead of immediately forking the notebook.
The modal will display:

1. A list of forked copies of the notebook that user can click to open the notebook in a new tab
2. A button to allow the user fork another copy of the notebook
3. A button at top right to close the modal

If the user has not forked the notebook previously, then the current behavior should be used (immediately copy the notebook).

What Happened

Now I have two copies of the same notebook with different changes.

(if applicable) notebook that reproduces bug

Applicable to any notebook that you have already forked.

[bcolloran]

thanks for filing this issue @imranariffin !

[imranariffin]

@bcolloran @wlach
Are we going forward with this requested feature? Just needed to double check before I start working on it.

[bcolloran]

Yea, I think it sounds like a good idea @imranariffin

I'd suggest clarification of the behavior: the modal should only open if the user has previously forked the NB being viewed; If the user has not forked the notebook previously, then the current behavior should be used (immediately copy the notebook)

[imranariffin]

Alright, gotcha!

…

On Thu., Feb. 27, 2020, 5:36 p.m. bcolloran, ***@***.***> wrote: Yea, I think it sounds like a good idea @imranariffin <https://github.com/imranariffin> I'd suggest clarification of the behavior: the modal should only open if the user has previously forked the NB being viewed; If the user has not forked the notebook previously, then the current behavior should be used (immediately copy the notebook) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2685?email_source=notifications&email_token=ABKSPKYXDEMGNAOC6NIJ3STRFA55PA5CNFSM4KTQSDZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGHJ6A#issuecomment-592213240>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKSPKYRIDBWOBSTB24RGFLRFA55PANCNFSM4KTQSDZQ> .