Add Type checking step?

[ChrisBarker-NOAA]

What should we add?

There are a fair bit (complete?, no idea) of type annotations in the code.

It's not a great idea to have the annotations and not be running a type checker on them. Bad / incorrect annotations are worse that no annotations.

I have no experience with type checkers, but it seems MyPy is the most used now (though pyright is also ...).

Here's some advice on how to get started:

https://mypy.readthedocs.io/en/latest/existing_code.html#using-mypy-with-an-existing-codebase

@ocefpaf: Do you have any experience setting this up?

Reference

No response

[ocefpaf]

@ocefpaf: Do you have any experience setting this up?

I usually set a linter, like .pre-commits, to check where type checking is missing and run mypy. I can start a PR here for this, or we can add to the GSoC heap. It kind of falls into the test improvement category we created there.

[ChrisBarker-NOAA]

add to the GSoC heap.

Sounds good to me, unless you are bored and looking for something to do :-)