Skip to content

Commit fb10466

Browse files
committed
chore(omz-pnpm-plugin): default to v1.1.0, a mirror of upstream
Upstream ntnyq/omz-plugin-pnpm merged the PNPM_HOME fix (rewritten, with tests; the plugin no longer calls pnpm on shell start). Upstream publishes no tags, so the itplusx fork now serves as tag source: v1.1.0 points at upstream main a5c3b08. Bump the feature to 1.0.1 with that default ref.
1 parent 4551943 commit fb10466

4 files changed

Lines changed: 17 additions & 13 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Custom [Dev Container Features](https://containers.dev/implementors/features/) m
1616
```json
1717
"features": {
1818
"ghcr.io/itplusx/devcontainer-features/shared-pnpm-store:1.1.0": {},
19-
"ghcr.io/itplusx/devcontainer-features/omz-pnpm-plugin:1.0.0": {}
19+
"ghcr.io/itplusx/devcontainer-features/omz-pnpm-plugin:1.0.1": {}
2020
}
2121
```
2222

‎src/omz-pnpm-plugin/NOTES.md‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,20 @@
1414
## Why a fork
1515

1616
The original [ntnyq/omz-plugin-pnpm](https://github.com/ntnyq/omz-plugin-pnpm)
17-
is unmaintained and mishandles `PNPM_HOME`:
17+
used to mishandle `PNPM_HOME`:
1818

19-
- when `pnpm -g bin` fails (fresh container, bin dir not on `PATH`) it still
20-
runs `export PNPM_HOME=""`, and pnpm treats an empty `PNPM_HOME` as the
21-
current directory. Every pnpm call then creates `global/` and
19+
- when `pnpm -g bin` failed (fresh container, bin dir not on `PATH`) it still
20+
ran `export PNPM_HOME=""`, and pnpm treats an empty `PNPM_HOME` as the
21+
current directory. Every pnpm call then created `global/` and
2222
`package-manager-store/` in your project root.
23-
- when `pnpm -g bin` succeeds it overrides `PNPM_HOME` with the bin dir. On
23+
- when `pnpm -g bin` succeeded it overrode `PNPM_HOME` with the bin dir. On
2424
pnpm 11+ that is `$PNPM_HOME/bin`, which moves the package-manager store out
2525
of the volume that [`shared-pnpm-store`](../shared-pnpm-store) mounts.
2626

27-
The fork leaves a pre-set `PNPM_HOME` alone and never exports an empty one.
28-
Aliases are unchanged.
27+
Both are fixed upstream since September 2026 (the plugin no longer calls pnpm
28+
on shell start at all). Upstream publishes no tags, so the fork exists as a
29+
tag source: `v1.0.0` is the original itplusx fix, `v1.1.0` and later mirror
30+
upstream commits verbatim. Aliases are unchanged either way.
2931

3032
## Pairing with `shared-pnpm-store`
3133

@@ -39,7 +41,7 @@ does not undo that.
3941
"plugins": "git docker"
4042
},
4143
"ghcr.io/itplusx/devcontainer-features/shared-pnpm-store:1.1.0": {},
42-
"ghcr.io/itplusx/devcontainer-features/omz-pnpm-plugin:1.0.0": {}
44+
"ghcr.io/itplusx/devcontainer-features/omz-pnpm-plugin:1.0.1": {}
4345
}
4446
```
4547

@@ -60,4 +62,5 @@ source). Without oh-my-zsh the feature installs cleanly and does nothing.
6062

6163
| Version | Notes |
6264
| ------- | --------------- |
65+
| 1.0.1 | Default `ref` is `v1.1.0`, a mirror of upstream after the `PNPM_HOME` fix landed there |
6366
| 1.0.0 | Initial release |

‎src/omz-pnpm-plugin/devcontainer-feature.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
{
22
"name": "oh-my-zsh pnpm plugin",
33
"id": "omz-pnpm-plugin",
4-
"version": "1.0.0",
4+
"version": "1.0.1",
55
"documentationURL": "https://github.com/itplusx/devcontainer-features/tree/main/src/omz-pnpm-plugin",
6-
"description": "Installs the itplusx fork of the omz-plugin-pnpm oh-my-zsh plugin (pnpm aliases) into the remote user's oh-my-zsh custom plugins and activates it. The fork respects a pre-set PNPM_HOME and never exports an empty one.",
6+
"description": "Installs the omz-plugin-pnpm oh-my-zsh plugin (pnpm aliases) from the itplusx tag mirror into the remote user's oh-my-zsh custom plugins and activates it. The plugin respects a pre-set PNPM_HOME and never leaves it empty.",
77
"options": {
88
"ref": {
99
"type": "string",
10-
"default": "v1.0.0",
10+
"default": "v1.1.0",
1111
"proposals": [
12+
"v1.1.0",
1213
"v1.0.0",
1314
"main"
1415
],

‎src/omz-pnpm-plugin/install.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
set -euo pipefail
44

5-
REF="${REF:-v1.0.0}"
5+
REF="${REF:-v1.1.0}"
66
ACTIVATE="${ACTIVATE:-true}"
77
USERNAME=${USERNAME:-${_REMOTE_USER:-}}
88
USER_HOME=${_REMOTE_USER_HOME:-}

0 commit comments

Comments
 (0)