fix: populate empty LICENSE file with standard MIT text#33
Open
dougborg wants to merge 1 commit into
Open
Conversation
The LICENSE file was added in #14 but committed empty (0 bytes). package.json declares "license": "MIT" and the PR title was "Add license and lobehub badge", so MIT was clearly the intent. This adds the canonical MIT text with the maintainer's copyright. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a repository compliance/distribution gap by populating the previously empty LICENSE file with the canonical MIT license text, aligning the source tree with the existing "license": "MIT" declaration in package.json and improving detection by GitHub and license scanners.
Changes:
- Populate
LICENSEwith the standard MIT license text. - Add the project’s copyright line (
(c) 2025 Jack Senechal).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository's
LICENSEfile is currently empty (0 bytes). It was added in #14 ("Add license and lobehub badge") but committed without content.package.jsondeclares"license": "MIT", npm publishes the package as MIT, and the PR title makes the intent clear — but the canonical license text isn't actually present in the source tree. This is a small but worth-fixing gap, since downstream consumers (forks, redistributors, license scanners like FOSSA / GitHub's license detection) rely on the LICENSE file content rather than just thepackage.jsonfield.This PR populates
LICENSEwith the standard MIT text and your copyright (year derived from the first commit, August 2025). No other changes.Test plan
LICENSEis now non-empty and contains the canonical MIT textpackage.json: "license": "MIT")Happy to adjust the copyright line if you'd prefer a different format (e.g., year range, "Jack Senechal and contributors", etc.).
For context: I'm working on adding a macOS/ImageCaptureCore backend to scan-mcp in a fork. Filing this license fix first as a small, independent contribution before sending anything larger your way. 🙂
🤖 Generated with Claude Code