Skip to content

fix: populate empty LICENSE file with standard MIT text#33

Open
dougborg wants to merge 1 commit into
jacksenechal:mainfrom
dougborg:fix/empty-license-file
Open

fix: populate empty LICENSE file with standard MIT text#33
dougborg wants to merge 1 commit into
jacksenechal:mainfrom
dougborg:fix/empty-license-file

Conversation

@dougborg

Copy link
Copy Markdown

Summary

The repository's LICENSE file is currently empty (0 bytes). It was added in #14 ("Add license and lobehub badge") but committed without content.

package.json declares "license": "MIT", npm publishes the package as MIT, and the PR title makes the intent clear — but the canonical license text isn't actually present in the source tree. This is a small but worth-fixing gap, since downstream consumers (forks, redistributors, license scanners like FOSSA / GitHub's license detection) rely on the LICENSE file content rather than just the package.json field.

This PR populates LICENSE with the standard MIT text and your copyright (year derived from the first commit, August 2025). No other changes.

Test plan

  • LICENSE is now non-empty and contains the canonical MIT text
  • Copyright line matches existing intent (package.json: "license": "MIT")
  • GitHub's repo sidebar will now show "MIT license" instead of a "License" placeholder
  • License scanners (FOSSA, GitHub Linguist) will detect MIT correctly

Happy to adjust the copyright line if you'd prefer a different format (e.g., year range, "Jack Senechal and contributors", etc.).


For context: I'm working on adding a macOS/ImageCaptureCore backend to scan-mcp in a fork. Filing this license fix first as a small, independent contribution before sending anything larger your way. 🙂

🤖 Generated with Claude Code

The LICENSE file was added in #14 but committed empty (0 bytes).
package.json declares "license": "MIT" and the PR title was
"Add license and lobehub badge", so MIT was clearly the intent.
This adds the canonical MIT text with the maintainer's copyright.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 21, 2026 20:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a repository compliance/distribution gap by populating the previously empty LICENSE file with the canonical MIT license text, aligning the source tree with the existing "license": "MIT" declaration in package.json and improving detection by GitHub and license scanners.

Changes:

  • Populate LICENSE with the standard MIT license text.
  • Add the project’s copyright line ((c) 2025 Jack Senechal).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants