From 237f4467da28f3116acb47a3b95a2ae4c4c5c973 Mon Sep 17 00:00:00 2001 From: Jingsheng Wang Date: Fri, 22 May 2026 17:50:39 -0700 Subject: [PATCH 1/4] Implement gkeauthplugin --- README.md | 6 ++++-- src/gcloud-cli/devcontainer-feature.json | 11 +++++++++-- src/gcloud-cli/install.sh | 8 ++++++++ 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 640dff0..9c99909 100644 --- a/README.md +++ b/README.md @@ -31,13 +31,15 @@ These examples show how to use features from this repository in a devcontainer: } ``` -Or use individual features: +Or use individual features with an additonal plugin: ```jsonc { "image": "mcr.microsoft.com/devcontainers/base:ubuntu", "features": { - "ghcr.io/jajera/features/gcloud-cli:1": {} + "ghcr.io/jajera/features/gcloud-cli:1": { + "installGkeAuthPlugin": true + } } } ``` diff --git a/src/gcloud-cli/devcontainer-feature.json b/src/gcloud-cli/devcontainer-feature.json index da6c9d9..2083122 100644 --- a/src/gcloud-cli/devcontainer-feature.json +++ b/src/gcloud-cli/devcontainer-feature.json @@ -1,7 +1,14 @@ { "name": "Google Cloud CLI", "id": "gcloud-cli", - "version": "1.0.1", + "version": "1.1.0", "description": "Installs Google Cloud CLI (gcloud) for Google Cloud Platform development.", - "documentationURL": "https://cloud.google.com/sdk/docs/install" + "documentationURL": "https://cloud.google.com/sdk/docs/install", + "options": { + "installGkeAuthPlugin": { + "type": "boolean", + "default": false, + "description": "Install the GKE gcloud auth plugin for kubectl authentication." + } + } } diff --git a/src/gcloud-cli/install.sh b/src/gcloud-cli/install.sh index 89ba197..6ef5fe4 100755 --- a/src/gcloud-cli/install.sh +++ b/src/gcloud-cli/install.sh @@ -296,4 +296,12 @@ export CLOUDSDK_PYTHON="$INSTALL_DIR/platform/bundledpythonunix/bin/python3" echo "⚠️ Warning: Could not initialize gcloud automatically. You may need to run 'gcloud init' manually." } +# Install GKE Auth Plugin if requested +if [ "${INSTALLGKEAUTHPLUGIN}" = "true" ] || [ "${INSTALL_GKE_AUTH_PLUGIN}" = "true" ]; then + echo "📦 Installing gke-gcloud-auth-plugin..." + "$INSTALL_DIR/bin/gcloud" components install gke-gcloud-auth-plugin --quiet || { + echo "⚠️ Warning: Could not install gke-gcloud-auth-plugin automatically." + } +fi + echo "✅ Google Cloud CLI installation complete!" From 90a0eedb555eb59d09dd1b3967a93978abfd3d5e Mon Sep 17 00:00:00 2001 From: Jingsheng Wang Date: Mon, 13 Jul 2026 10:27:44 -0700 Subject: [PATCH 2/4] let's publish --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 9c99909..612867d 100644 --- a/README.md +++ b/README.md @@ -21,12 +21,12 @@ These examples show how to use features from this repository in a devcontainer: { "image": "mcr.microsoft.com/devcontainers/base:ubuntu", "features": { - "ghcr.io/jajera/features/ag:1": {}, - "ghcr.io/jajera/features/agentcore-cli:1": {}, - "ghcr.io/jajera/features/amazon-q-cli:1": {}, - "ghcr.io/jajera/features/aws-sam-cli:1": {}, - "ghcr.io/jajera/features/gcloud-cli:1": {}, - "ghcr.io/jajera/features/zip:1": {} + "ghcr.io/skyred/features/ag:1": {}, + "ghcr.io/skyred/features/agentcore-cli:1": {}, + "ghcr.io/skyred/features/amazon-q-cli:1": {}, + "ghcr.io/skyred/features/aws-sam-cli:1": {}, + "ghcr.io/skyred/features/gcloud-cli:1": {}, + "ghcr.io/skyred/features/zip:1": {} } } ``` @@ -37,7 +37,7 @@ Or use individual features with an additonal plugin: { "image": "mcr.microsoft.com/devcontainers/base:ubuntu", "features": { - "ghcr.io/jajera/features/gcloud-cli:1": { + "ghcr.io/skyred/features/gcloud-cli:1": { "installGkeAuthPlugin": true } } From d38f780a7853ad6ca87addfd10634c0c0ae8b274 Mon Sep 17 00:00:00 2001 From: Jingsheng Wang Date: Mon, 13 Jul 2026 10:45:08 -0700 Subject: [PATCH 3/4] update workflow --- .github/workflows/release.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index a0b12b8..54ef6b0 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -1,10 +1,12 @@ name: "Release dev container features" on: - workflow_dispatch: + release: + types: [published] # Triggers automatically when you hit "Publish Release" + workflow_dispatch: # Keeps the manual "Run workflow" button just in case jobs: deploy: - if: ${{ github.ref == 'refs/heads/main' }} + # Removed the 'if' condition so it can process release events cleanly runs-on: ubuntu-latest permissions: contents: write From 27dee6b8c968eda87e9ea681dc933d0869e98a9e Mon Sep 17 00:00:00 2001 From: Jingsheng Wang Date: Mon, 13 Jul 2026 10:54:33 -0700 Subject: [PATCH 4/4] bump the version --- src/gcloud-cli/devcontainer-feature.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gcloud-cli/devcontainer-feature.json b/src/gcloud-cli/devcontainer-feature.json index 2083122..ef90e12 100644 --- a/src/gcloud-cli/devcontainer-feature.json +++ b/src/gcloud-cli/devcontainer-feature.json @@ -1,7 +1,7 @@ { "name": "Google Cloud CLI", "id": "gcloud-cli", - "version": "1.1.0", + "version": "1.1.1", "description": "Installs Google Cloud CLI (gcloud) for Google Cloud Platform development.", "documentationURL": "https://cloud.google.com/sdk/docs/install", "options": {