return in finally swallows exceptions

[iritkatriel]

In

pypsrp/src/psrp/_connection/wsman.py

Line 746 in d2a3eca

return

there is a return statement in a finally block, which would swallow any in-flight exception.
and

pypsrp/src/psrp/_connection/wsman.py

Line 1110 in d2a3eca

return

This means that if a BaseException (such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[jborean93]

Thanks for the information, it's certainly somewhat surprising but I can understand why it is happening and will have to update the code.