Fixes for buttons in the tool panel#279
Open
kristoff3r wants to merge 2 commits into
Open
Conversation
I noticed that clicking some of the tool buttons didn't work, and after some (AI-assisted) triaging I realized that a bunch of the drag operations were firing when clicking and immediately going back to object mode, plus some insufficient interaction guards. After fixing this the object mode button no longer worked, which I fixed by always dismissing active modals. The whole system feels very brittle and it would be surprising if it's entirely correct now, even though I didn't find any issues when clicking around a bit. This part of the editor needs better abstractions so the individual operators can express their intent and not deal with the underlying implementation.
jbuehler23
approved these changes
May 23, 2026
Owner
jbuehler23
left a comment
jbuehler23
left a comment
There was a problem hiding this comment.
I think as discussed on discord, this entire suite needs to be cleaned up properly. As I plan to move more toward QWER based editing (Selection, Transform, Rotation, Scale, respectively). This means the Object Mode kind of gets moved out into a dedicated Select tool.
Appreciate this is a best effort for now, and happy if it Just Works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that clicking some of the tool buttons didn't work, and after some (AI-assisted) triaging I realized that a bunch of the drag operations were firing when clicking and immediately going back to object mode, plus some insufficient interaction guards. After fixing this the object mode button no longer worked, which I fixed by always dismissing active modals.
The whole system feels very brittle and it would be surprising if it's entirely correct now, even though I didn't find any issues when clicking around a bit. This part of the editor needs better abstractions so the individual operators can express their intent and not deal with the underlying implementation.