Does not build on Linux

[cbmeeks]

Running make all returns this:

Any ideas what's missing?

Thanks

[sagarc03]

remove/comment this line

doomenstein-3d/Makefile

Line 51 in faef6e5

all: dirs build

Also make sure this points to the right cland/ld

doomenstein-3d/Makefile

Lines 3 to 4 in faef6e5

	CC = $(shell brew --prefix llvm)/bin/clang
	LD = $(shell brew --prefix llvm)/bin/clang

[cbmeeks]

That seemed to fix the Makefile issue.
But now it's complaining about SDL not being found. I'm reasonably sure that SDL is installed (I use Fedora, BTW).

Everything I find online that says how to install SDL has been done and dnf reports "nothing to do".

Any ideas on this one?

Thanks!!

[sagarc03]

run

make libs

[sagarc03]

PS: this is submodule, so

cd lib/SDL
git submodule init
git submodule update

before you run

make libs

[sagarc03]

Sorry for so many comments but for anyone who stumbles on this issue

Make sure your CC and LD are set to the right clang in the Makefile, jdah uses one installed via brew so they are pointing to that. So make it point to your system clang

 CC = $(shell brew --prefix llvm)/bin/clang 
 LD = $(shell brew --prefix llvm)/bin/clang 

Remove build from the Makefile as it is not a valid target.

 all: dirs build 

This repo uses git submodules, following commands will ensure you will have the SDL source locally.

cd lib/SDL
git submodule init
git submodule update

Finally, before compiling anything make sure you run,

make libs

This will get rid of any missing SDL errors.

Extra

If the compiler complains about bool as invalid types add

#include <stdbool.h>

to both main_doom.c and main_wolf.c.

This comment summarizes previous comments.

[emmalexandria]

Sorry for so many comments but for anyone who stumbles on this issue

Make sure your CC and LD are set to the right clang in the Makefile, jdah uses one installed via brew so they are pointing to that. So make it point to your system clang

 CC = $(shell brew --prefix llvm)/bin/clang 
 LD = $(shell brew --prefix llvm)/bin/clang 

Remove build from the Makefile as it is not a valid target.

 all: dirs build 

This repo uses git submodules, following commands will ensure you will have the SDL source locally.

cd lib/SDL
git submodule init
git submodule update

Finally, before compiling anything make sure you run,

make libs

This will get rid of any missing SDL errors.

Extra

If the compiler complains about bool as invalid types add

#include <stdbool.h>

to both main_doom.c and main_wolf.c.

This comment summarizes previous comments.

Thank you for writing this out. I just wanted to add that personally, to get it to run on Linux I had to go into the source code for both projects and switch the SDL includes to:

#include <SDL2/SDL.h>

In addition, the path to load the level in main_doom.c assumes that the program is being run from the base of the project. To get it to run from the bin dir, line 553 needs to be:

!(ret = load_sectors("../res/level.txt")),

[backendiain]

@emma-alexandria Has already posted in some great tips! Thanks for that!

@jdah Also big thanks your way, thanks for taking the time to build and share this example. Really interesting stuff.

For anyone that's maybe using the WSL (Win 10 WSL2, Ubuntu 20.04), I took some notes that helped me getting everything compiled.

In Linux, this should at least in principle be the same.

So anyway, here's some pointers...

---

# FOR WSL, UBUNTU 20.04

# Make sure you've got make installed
sudo apt install make

# Make sure you have done the following in the WSL on Ubuntu 20.04:

sudo apt update && sudo apt install build-essential && sudo apt-get install manpages-dev
sudo apt-get install build-essential procps curl file git
install homebrew: https://docs.brew.sh/Homebrew-on-Linux

curl -fsSL -o install.sh https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh

Then run wherever you've downloaded that install.sh:
./install.sh

Guide:
https://docs.brew.sh/Homebrew-on-Linux

sudo apt install cmake
sudo apt install pkg-config
sudo apt install libsdl2-dev g++

# The Makefile rsync command might not work in the dirs: target in Makefile.

This worked for me:

dirs: $(BIN)

    ORIGINAL:
    rsync -a -v --include='*/' --exclude='*' "src" "bin"

    UPDATED:
    rsync -a -v --include='*/' "src" "bin"

# Make sure the .gitmodules is using the SDL2 branch SDL and SDL_image

I think in my tinkering this was my fault and I got the SDL3 branch, by default.

[submodule "lib/SDL_image"]
	path = lib/SDL_image
	url = https://github.com/libsdl-org/SDL_image.git
	branch = SDL2
[submodule "lib/SDL"]
	path = lib/SDL
	url = https://github.com/libsdl-org/SDL.git
	branch = SDL2

If you edit the .gitmodules file you then run:
git submodules update --remote

It will then pull down the correct branch you need.

# If you've accidentally compiled with SDL3 from the wrong branch then first run
make clean

This will purge the old files from the bin directory.

# After that, run the make target "libs"
make libs

# Make sure your libs include dir is known to the gcc compiler/linker

ORIGINAL:
INCFLAGS = -iquotesrc

UPDATED:
INCFLAGS = -iquotesrc -Ibin/sdl/include -Ibin/sdl/include-config-

# Then, make
make doom

Now, if you're actually on Windows unless you've set the WSL up to have some sort of GUI support you won't be able to run the resulting executable. It'll be for Ubuntu 20.04, not Windows.

You can boot it on the WSL:
./bin/doom

You'll then get this message

error: XDG_RUNTIME_DIR not set in the environment.
SDL failed to initialize: No available video device

However, at least for me, having a working build output in the WSL was vital to getting the Windows equivalent working too.

It at least gets you to a point where you know it isn't the C code causing trouble but compiler/linker issues.

With this checklist sorted building with the Makefile was fine.

Hope that helps!

P.S. How I got things running on Windows here:
#4 (comment)

Makefile

print-%:; @echo $($*)

CC = gcc
LD = gcc

# library paths
PATH_LIB = lib
PATH_SDL = $(PATH_LIB)/SDL

INCFLAGS = -iquotesrc -Ibin/sdl/include -Ibin/sdl/include-config-

CCFLAGS  = -std=c1x
CCFLAGS += -O2
CCFLAGS += -g
#CCFLAGS += -fbracket-depth=1024
CCFLAGS += -ftemplate-backtrace-limit=0
CCFLAGS += -Wall
CCFLAGS += -Wextra
CCFLAGS += -Wpedantic
CCFLAGS += -Wfloat-equal
CCFLAGS += -Wstrict-aliasing
CCFLAGS += -Wswitch-default
CCFLAGS += -Wformat=2
CCFLAGS += -Wno-newline-eof
CCFLAGS += -Wno-unused-parameter
CCFLAGS += -Wno-strict-prototypes
CCFLAGS += -Wno-fixed-enum-extension
CCFLAGS += -Wno-int-to-void-pointer-cast
CCFLAGS += -Wno-gnu-statement-expression
CCFLAGS += -Wno-gnu-compound-literal-initializer
CCFLAGS += -Wno-gnu-zero-variadic-macro-arguments
CCFLAGS += -Wno-gnu-empty-struct
CCFLAGS += -Wno-gnu-auto-type
CCFLAGS += -Wno-gnu-empty-initializer
CCFLAGS += -Wno-gnu-pointer-arith
CCFLAGS += -Wno-c99-extensions
CCFLAGS += -Wno-c11-extensions

LDFLAGS = -lm

BIN = bin
SRC = $(shell find src -name "*.c")
OBJ = $(SRC:%.c=$(BIN)/%.o)
DEP = $(SRC:%.c=$(BIN)/%.d)
OUT = $(BIN)/game

-include $(DEP)

UNAME := $(shell uname -s)
ifeq ($(UNAME),Darwin)
	CC = $(shell brew --prefix llvm)/bin/clang
	LD = $(shell brew --prefix llvm)/bin/clang

	INCFLAGS += -I$(PATH_SDL)/include
	LDFLAGS += $(shell $(BIN)/sdl/sdl2-config --prefix=$(BIN) --static-libs)
else ifeq ($(UNAME),Linux)
	LDFLAGS += -lSDL2
endif

$(BIN):
	mkdir -p $@

dirs: $(BIN)
#rsync -a -v --include='*/' --exclude='*' "src" "bin" # original
	rsync -a -v --include='*/' "src" "bin"

lib-sdl:
	mkdir -p $(BIN)/sdl
	cmake -S $(PATH_SDL) -B $(BIN)/sdl
	cd $(BIN)/sdl && make -j 10
	chmod +x $(BIN)/sdl/sdl2-config
	mkdir -p $(BIN)/lib
	cp $(BIN)/sdl/libSDL2.a $(BIN)/lib

libs: lib-sdl

$(OBJ): $(BIN)/%.o: %.c
	$(CC) -o $@ -MMD -c $(CCFLAGS) $(INCFLAGS) $<

doom: dirs $(BIN)/src/main_doom.o
	$(LD) -o bin/doom $(BIN)/src/main_doom.o $(LDFLAGS)

doom_win: dirs $(BIN)/src/main_doom.o
	gcc -c src/*.c -g -Wall -m64 -I include -I C:\sdl\x86_64-w64-mingw32\include

wolf: dirs $(BIN)/src/main_wolf.o
	$(LD) -o bin/wolf $(BIN)/src/main_wolf.o $(LDFLAGS)

all: dirs doom wolf

clean:
	rm -rf bin

[Link-Games]

when i type make doom i get this error
make doom
rsync -a --include '/' --exclude '' "src" "bin"
/bin/sh: 1: rsync: not found
make: *** [Makefile:64: dirs] Error 127

[AlexandreCGMeier]

@Link-Games you have loads of answers to this exact question above. Please try those and report back once something shows up that isn't discussed above.

[backendiain]

@Link-Games

when i type make doom i get this error make doom rsync -a --include '/' --exclude '' "src" "bin" /bin/sh: 1: rsync: not found make: *** [Makefile:64: dirs] Error 127

You most likely don't have the rsync package installed on your system.

Install on Linux (in this case Ubuntu)
https://bytexd.com/install-and-use-rsync-on-ubuntu/#google_vignette

Windows
https://www.msys2.org/wiki/MSYS2-installation/
https://packages.msys2.org/package/rsync

Mac
Brew is probably your best route.
https://clubmate.fi/update-rsync-on-osx-with-homebrew

[morpheuslord]

I am having this issue :

rsync -a --include '*/' --exclude '*' "src" "bin"
gcc -o bin/src/main_doom.o -MMD -c -std=c2x -O2 -g -fbracket-depth=1024 -fmacro-backtrace-limit=0 -Wall -Wextra -Wpedantic -Wfloat-equal -Wstrict-aliasing -Wswitch-default -Wformat=2 -Wno-newline-eof -Wno-unused-parameter -Wno-strict-prototypes -Wno-fixed-enum-extension -Wno-int-to-void-pointer-cast -Wno-gnu-statement-expression -Wno-gnu-compound-literal-initializer -Wno-gnu-zero-variadic-macro-arguments -Wno-gnu-empty-struct -Wno-gnu-auto-type -Wno-gnu-empty-initializer -Wno-gnu-pointer-arith -Wno-c99-extensions -Wno-c11-extensions -iquotesrc src/main_doom.c
gcc: error: unrecognized command-line option ‘-fbracket-depth=1024’
gcc: error: unrecognized command-line option ‘-fmacro-backtrace-limit=0’; did you mean ‘-ftemplate-backtrace-limit=’?

[PurpleAlien]

The options -fbracket-depth and -fmacro-backtrace-limit are clang, not gcc. So either switch to clang, or remove those two options when using gcc.

[morpheuslord]

The options -fbracket-depth and -fmacro-backtrace-limit are clang, not gcc. So either switch to clang, or remove those two options when using gcc.

No use still having this issue

rsync -a -v --include='*/' "src" "bin"
sending incremental file list
src/
src/main_doom.c
src/main_wolf.c

sent 29,374 bytes  received 58 bytes  58,864.00 bytes/sec
total size is 29,156  speedup is 0.99
gcc -o bin/src/main_doom.o -MMD -c -std=c2x -O2 -g -fbracket-depth=1024 -fmacro-backtrace-limit=0 -Wall -Wextra -Wpedantic -Wfloat-equal -Wstrict-aliasing -Wswitch-default -Wformat=2 -Wno-newline-eof -Wno-unused-parameter -Wno-strict-prototypes -Wno-fixed-enum-extension -Wno-int-to-void-pointer-cast -Wno-gnu-statement-expression -Wno-gnu-compound-literal-initializer -Wno-gnu-zero-variadic-macro-arguments -Wno-gnu-empty-struct -Wno-gnu-auto-type -Wno-gnu-empty-initializer -Wno-gnu-pointer-arith -Wno-c99-extensions -Wno-c11-extensions -iquotesrc -Ibin/sdl/include -Ibin/sdl/include-config- src/main_doom.c
gcc: error: unrecognized command-line option ‘-fbracket-depth=1024’
gcc: error: unrecognized command-line option ‘-fmacro-backtrace-limit=0’; did you mean ‘-ftemplate-backtrace-limit=’?
make: *** [Makefile:77: bin/src/main_doom.o] Error 1

The options -fbracket-depth and -fmacro-backtrace-limit are clang, not gcc. So either switch to clang, or remove those two options when using gcc.

No use still having this issue

rsync -a -v --include='*/' "src" "bin"
sending incremental file list
src/
src/main_doom.c
src/main_wolf.c

sent 29,374 bytes  received 58 bytes  58,864.00 bytes/sec
total size is 29,156  speedup is 0.99
gcc -o bin/src/main_doom.o -MMD -c -std=c2x -O2 -g -fbracket-depth=1024 -fmacro-backtrace-limit=0 -Wall -Wextra -Wpedantic -Wfloat-equal -Wstrict-aliasing -Wswitch-default -Wformat=2 -Wno-newline-eof -Wno-unused-parameter -Wno-strict-prototypes -Wno-fixed-enum-extension -Wno-int-to-void-pointer-cast -Wno-gnu-statement-expression -Wno-gnu-compound-literal-initializer -Wno-gnu-zero-variadic-macro-arguments -Wno-gnu-empty-struct -Wno-gnu-auto-type -Wno-gnu-empty-initializer -Wno-gnu-pointer-arith -Wno-c99-extensions -Wno-c11-extensions -iquotesrc -Ibin/sdl/include -Ibin/sdl/include-config- src/main_doom.c
gcc: error: unrecognized command-line option ‘-fbracket-depth=1024’
gcc: error: unrecognized command-line option ‘-fmacro-backtrace-limit=0’; did you mean ‘-ftemplate-backtrace-limit=’?
make: *** [Makefile:77: bin/src/main_doom.o] Error 1

you didnt even TRY to do what he said