Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

golang pack go lint can't handle dir with a : in the name #53

Description

@rawlingsj

From slack a user with bitbucketserver tried the golang quickstart but it fails in the release pipeline with

Makefile:24: *** target pattern contains no `%'.  Stop.

This can be recreated by creating a golang quickstart in your go path under a git server that includes a : port e.g.

~/go/src/mybitbucketserver:1234/rawlingsj/foo

Now run make build in that folder.

The issue is the paths that go list ./... | grep -v /vendor | grep -v generated from https://github.com/jenkins-x/draft-packs/blob/dfda4a9/packs/go/Makefile#L9 returns contain the : which causes issues in the Makefile targets.

A hack to get the quickstart going in this scenario was to replace : with _ in the PKGS var but that disabled the lint so is a pretty horrid workaround.

We should come up with a way to escape or workaround better.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions