configure MSRV#15
Draft
danieleades wants to merge 2 commits into
Draft
Conversation
danieleades
commented
Nov 18, 2023
| CARGO_NET_GIT_FETCH_WITH_CLI: true | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: taiki-e/install-action@cargo-no-dev-deps |
Author
There was a problem hiding this comment.
this allows checking the MSRV for the non-dev deps only (since this is the MSRV that downstream users are impacted by). This means you can freely use newer versions + syntax for dev-deps
danieleades
commented
Nov 18, 2023
danieleades
force-pushed
the
msrv
branch
2 times, most recently
from
ac668de to
70061e9
Compare
danieleades
commented
Nov 19, 2023
| @@ -0,0 +1,10 @@ | |||
| version: 2 | |||
| updates: | |||
| - package-ecosystem: cargo | |||
Author
There was a problem hiding this comment.
can safely bump dependencies using dependabot since any change to the MSRV introduced by dependency updates will be caught in CI
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is stacked on #14
Cargo.tomlrust-version)