Fix impl ToTokens for SpannedValue#22
Open
H2CO3 wants to merge 1 commit into
Open
Conversation
The `ToTokens` impl was previously abused as a proxy for `Spanned::span()` (through the blanket impl). This meant that whether or not the inner value was `ToTokens`, this wrapper always produced an empty group, just for the sake of returning _something_ that had the span. Since `SpannedValue` is supposed to be a transparent wrapper, we hereby fix this bug/surprising behavior. We furthermore implement an additional `span()` inherent method, that serves as a universal getter even when the inner type (and therefore `SpannedValue<T>` itself) does not implement `ToTokens`.
Author
|
ping @jf2048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ToTokensimpl was previously abused as a proxy forSpanned::span()(through the blanket impl). This meant that whether or not the inner value wasToTokens, this wrapper always produced an empty group, just for the sake of returning something that had the span.Since
SpannedValueis supposed to be a transparent wrapper, we hereby fix this bug/surprising behavior. We furthermore implement an additionalspan()inherent method, that serves as a universal getter even when the inner type (and thereforeSpannedValue<T>itself) does not implementToTokens.This fixes #21.