Sync up with fork

[jcpunk]

It looks like https://forge.puppet.com/modules/mindhive/ipmi/readme is a fork of this module. It would be interesting to see which changes there would be appropriate to pull into this module.

[damonmaria]

Hi @jcpunk. I'm the maintainer of the mindhive fork. This was really for our own purposes. While the CHANGELOG is fairly accurate as to changes I've made the rest of the documentation hasn't been touched much.

Obviously We're happy for any desirable changes we've done to be brought across to here.

[jhoblitt]

It looks like the major features are:

• user purging
• looking up the foreman facts
• user id allocation

I think the user purging could be upstream (this is so screaming for a native type).

At a glance it appears that the foreman fact lookup could be done as a helper class. Maybe it would be best as a standalone mod?

I honestly don't have my head around what the user id logic is doing... could someone explain what it does and why it is needed?

[damonmaria]

That was probably my first go at a Puppet module so it's probably not the greatest code.

I did add testing around it which explains the different scenarios it's trying to handle: https://github.com/mindhivenz/puppet-ipmi/blob/master/spec/classes/ipmi_spec.rb

From memory the user ID logic was so that the ID's could generated and handled automatically, rather than having to be supplied explicitly through Puppet.