Keyboard Shortcuts:Tab button in text area

[142ayushkumar]

Closes #15

[Demfier]

My my, what did you do change 336 files 😅

Try putting that js in init.html itself and see if it works

[Demfier]

Also, you still haven't given us the browser console error

[142ayushkumar]

@Demfier I didn't even opened 336 files i guess , i don't know how come i have made changes in so many files, but i tried too many times to make things work.
I have tried putting that in init.html too, it doesn't work.

[Demfier]

browser console error please!

[142ayushkumar]

[Demfier]

the $ you are using in the js isn't defined. Is jquery loading properly?

[142ayushkumar]

How can i check if jquery is loading properly or not?

[Demfier]

You can check it by doing a `window.jQuery` in the js console. ᐧ

[Demfier]

And where exactly did you add you js code? It should be after jquery has been loaded ᐧ

…

On 14 December 2017 at 19:08, Gaurav Sahu ***@***.***> wrote: You can check it by doing a `window.jQuery` in the js console. ᐧ

[kaustubhhiware]

You need to add node_modules in .gitignore, that is what's causing the large number of file changes.

Unless you do that, it will be really difficult for us to review this.

[142ayushkumar]

I have loaded jQuery before js code

[142ayushkumar]

Need some help here.

[kaustubhhiware]

So as per what I spoke with @142ayushkumar , changes in existing files have been made in init.html and my.js

[kaustubhhiware]

Need to write /static/js/my.js

See this: Another django project

[kaustubhhiware]

@142ayushkumar Could you please explicitly write what you are trying to solve with this PR?

Also, did you test it locally? Do not submit PR's which do not work locally / before testing.

Please mention which all shortcuts you have thought of, and which are implemented in this PR.

I tried using it locally, does not seem to work.

[kaustubhhiware]

It will help if you can mention all possible shortcuts you can think of. That way, you'll stay motivated if and when you work on them.

[142ayushkumar]

As the name suggests "Tab button in text area", i expected that when in text area tab button will be used it will give '\t'. Yes, i tested this locally and it didn't seemed to work in this project but when i tested the same code in some html and js files it works, see => http://jsfiddle.net/jz6J5/.
See #15 , demifier suggested to make a PR.

[142ayushkumar]

@Demfier and @kaustubhhiware , #39 takes care of this pr, by configuring codemirror tab button works as desired in this pr.