Syntax Highlighting

[142ayushkumar]

codemirror configured

[kaustubhhiware]

@142ayushkumar can you just pull from the master once?
That way, a review app will be auto-deployed.
This branch seems to be 4 commits behind master.

[142ayushkumar]

@kaustubhhiware Done!

[kaustubhhiware]

@142ayushkumar You have made your master branch level with this repo's master.
What you need to do is make syntax-highlighting branch level with this repo's master.

To give a preliminary idea, heroku needs an app.json file (added yesterday) to auto-deploy PR's. That is present in your master, but not in your syntax-highlighting

[142ayushkumar]

@kaustubhhiware , i have merged my branched with master now!

[kaustubhhiware]

@142ayushkumar Please refer to http://c0derunr-pr-39.herokuapp.com/

Seems code highlighting is not working.

[kaustubhhiware]

You have mentioned static/codemirror folder here. But it hasn't been added in your PR.

[kaustubhhiware]

[142ayushkumar]

But it is there locally 😕

[kaustubhhiware]

You have mentioned codemirror in .gitignore. Seems it's ignoring all codemirror folders.

I think you wanted to ignore ./codemirror. but gitignore makes it ignore ./static/codemirror as well. Check how you can fix this. Looks like an easy fix.

[142ayushkumar]

if i remove codemirror from .gitignore there will be a lot of files then.

[kaustubhhiware]

You need to see how to add ./codemirror to .gitignore, but not ignore ./static/codemirror

It is possible to NOT ignore certain files / folders in .gitignore. What you've done is not wrong, it's just incomplete.

[142ayushkumar]

./codemirror
!./static/codemirror
will do the work i guess

[kaustubhhiware]

Redeployed app.
Highllighting works, but language switcher stopped working. 😕

[kaustubhhiware]

Using static codemirror seems to overload files.
Can you first use some online alternative?

Then we can try to debug where the switcher is failing.

[142ayushkumar]

I didn't noticed

[142ayushkumar]

Yes, language switcher stopped working, to change language now we have to refresh the page.
I will try some other alternatives.

[142ayushkumar]

@kaustubhhiware ,I configured ace for syntax highlighting but the same problem is still there, after configuring language switcher doesn't work.

[142ayushkumar]

@kaustubhhiware , i think something is wrong with language selector anyway, by chosing some language the template doesn't change like Java.