Skip to content

Unexpected behaviour with a max_size of 0 #4

@jamiecobbett

Description

@jamiecobbett

If you create an LRUCache with a max_size of 0, it actually effectively creates a cache with a max_size of 1.

cache = LRUCache.new(max_size: 0)
=> #<LRUCache:0x00000004a01c30 @max_size=0, @default=nil, @ttl=0.0, @soft_ttl=0.0, @retry_delay=0.0, @pqueue=<PriorityQueue: []>, @data={}, @counter=0>
cache.store("a", 1)
=> 1
cache.keys
=> ["a"]
cache.store("b", 2)
=> 2
cache.keys
=> ["b"]

Whilst I appreciate that it might be an odd thing to do, it's something we did to (try to) disable the cache. I think there are two options: change the code to actually enforce a size of 0 or to raise an error if passed a size of 0.

I'm happy to try writing a Pull Request for either one, though I think the latter will be simpler.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions