From 7c8a94f697daf510d81396d605daa2910d80865e Mon Sep 17 00:00:00 2001
From: xiayu <xiayu@kingsoft.com>
Date: Thu, 30 Jul 2026 10:08:03 +0800
Subject: [PATCH] fix(feedback): bind ratings by response id

---
 src/utils/feedback.js         |  5 -----
 tests/feedback-utils.test.mjs | 10 ++++++++--
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/utils/feedback.js b/src/utils/feedback.js
index 34ffb9e..046920c 100644
--- a/src/utils/feedback.js
+++ b/src/utils/feedback.js
@@ -46,7 +46,6 @@ export function shouldRenderFeedbackControls(message, isStreaming, isLastMessage
   return Boolean(
     message?.role === 'model' &&
       textValue(message.responseId) &&
-      textValue(message.eventId) &&
       !(isStreaming && isLastMessage),
   );
 }
@@ -88,15 +87,11 @@ export function buildUpsertFeedbackPayload({
   }
   const payload = {
     ...buildGetFeedbackPayload({ agentId, sessionId, message }),
-    EventId: textValue(message?.eventId),
     Rating: normalized,
     Comment: String(comment || ''),
     TraceId: textValue(message?.traceId),
     RootSpanId: textValue(message?.rootSpanId),
   };
-  if (!payload.EventId) {
-    throw new Error('Message missing event id');
-  }
   return payload;
 }
 
diff --git a/tests/feedback-utils.test.mjs b/tests/feedback-utils.test.mjs
index e68556c..446ffe8 100644
--- a/tests/feedback-utils.test.mjs
+++ b/tests/feedback-utils.test.mjs
@@ -30,6 +30,14 @@ test('feedback utils expose assistant response feedback state', async () => {
     ),
     true,
   );
+  assert.equal(
+    feedback.shouldRenderFeedbackControls(
+      { role: 'model', responseId: 'resp_123' },
+      false,
+      true,
+    ),
+    true,
+  );
 
   assert.deepEqual(
     feedback.normalizeFeedback({
@@ -81,7 +89,6 @@ test('feedback utils build action payloads for up and down feedback', async () =
       AgentId: 'agent-1',
       SessionId: 'sess-1',
       ResponseId: 'resp_123',
-      EventId: 'ev_1',
       Rating: 'up',
       Comment: '',
       TraceId: 'trace-1',
@@ -101,7 +108,6 @@ test('feedback utils build action payloads for up and down feedback', async () =
       AgentId: 'agent-1',
       SessionId: 'sess-1',
       ResponseId: 'resp_123',
-      EventId: 'ev_1',
       Rating: 'down',
       Comment: '不准确',
       TraceId: 'trace-1',