Improved heuristic for wrapping long URLs on otherwise short lines

[tgross35]

For example, lines like this:

Link: https://github.com/kivikakk/comrak/commit/e34f51bea0946af4fa5b022a590d23611747a691

are formatted like this:

Link:
https://github.com/kivikakk/comrak/commit/e34f51bea0946af4fa5b022a590d23611747a691

I think one way to improve this would be to have a threshold for minimum line size before rewrapping, perhaps 25%. Then for a text width of 80, this would not wrap:

<!-- Prefix is 5 characters -->
Link: https://github.com/kivikakk/comrak/commit/e34f51bea0946af4fa5b022a590d23611747a691

<!-- Prefix is 22 characters -->
Lorem ipsum dolor sit https://github.com/kivikakk/comrak/commit/e34f51bea0946af4fa5b022a590d23611747a691

But this would:

<!-- Prefix is 27 characters -->
Lorem ipsum dolor sit amet
https://github.com/kivikakk/comrak/commit/e34f51bea0946af4fa5b022a590d23611747a691

[kivikakk]

I'm inclined to think that we should always produce a line closer to the width where possible (which is as it's currently implemented), but I'm open to the idea that this might be better. If someone's reading in a width-constrained environment, the URL (or SHA512 or whatever) being relatively more off the side of the screen doesn't really make a difference to readability, whereas the very short line on its own does.

Very open to implementations :) If it's clearly better we can probably just make it the default; otherwise we can add an option.

[aozerova]

Would it be alright for me to take a look through and see if I could give this issue a shot? 👀

[kivikakk]

Of course!! 🤍 I should warn you upfront: the wrapping logic in cm.rs is .. woof. Any improvement is welcome!

[aozerova]

Thank you!!! Excited to do my best!

I'd also be happy with any and all guidance you have (if that is okay to ask for)! I can give it a shot first and then check in, if that is alright with you?

Thank you so much for letting me give it a try (I missed Rust so much 😭)

[kivikakk]

I'd also be happy with any and all guidance you have (if that is okay to ask for)! I can give it a shot first and then check in, if that is alright with you?

Of course, absolutely. You are being far too kind lol, you're the one who should be being thanked here!!

Have fun and if it turns out to be as sticky as I fear, don't worry too much about it!