Cursor Bugbot finding on PR #146 (428b6769), low severity:
The lineSeen property on the pendingSuppress object is assigned at creation but never read. Only pendingSuppress.rule and pendingSuppress.reason are accessed (lines 1976–1978). The lineSeen field in the type definition and its assignment are dead code that can be removed.
Verified locally: grep -n lineSeen workers/src/orchestrate.ts returns only the two write sites (L1947 type, L1959 assignment). No reads.
Disposition on PR #146: waived for the v0.26.0 promote — no behavioral impact, and a fix here would re-touch orchestrate.ts (load-bearing per klappy://canon/constraints/release-validation-gate Rule 2) and force another full validator dispatch for a cosmetic cleanup. Tracking here for the next code beat that legitimately touches the audit code path.
Suggested fix: drop lineSeen from both the type annotation and the assignment object. ~3-line diff, no test changes needed (no behavioral surface).
Source: PR #146 review comment #146 (comment)
Cursor Bugbot finding on PR #146 (
428b6769), low severity:Verified locally:
grep -n lineSeen workers/src/orchestrate.tsreturns only the two write sites (L1947 type, L1959 assignment). No reads.Disposition on PR #146: waived for the v0.26.0 promote — no behavioral impact, and a fix here would re-touch
orchestrate.ts(load-bearing perklappy://canon/constraints/release-validation-gateRule 2) and force another full validator dispatch for a cosmetic cleanup. Tracking here for the next code beat that legitimately touches the audit code path.Suggested fix: drop
lineSeenfrom both the type annotation and the assignment object. ~3-line diff, no test changes needed (no behavioral surface).Source: PR #146 review comment #146 (comment)