Skip to content

export MinimumVersion() accessor #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
May 4, 2026
Merged

export MinimumVersion() accessor #3350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ const (
defaultMinimumVersion = "v1.34.0"
)

// MinimumVersion returns the minimum Kubernetes version Knative is built
// and tested against. The returned value has a leading "v" (e.g. "v1.34.0").
func MinimumVersion() string {
Copy link
Copy Markdown
Member

@dprotaso dprotaso May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing since we also have getMinimumVersion below.

Maybe we should just expose defaultMinimumVersion as DefaultKubernetesMinVersion const

and expose getMinimumVersion as KubernetesMinimumVersion()

return defaultMinimumVersion
}

func getMinimumVersion() string {
if v := os.Getenv(KubernetesMinVersionKey); v != "" {
return v
Expand Down
6 changes: 6 additions & 0 deletions version/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,9 @@ func TestVersionCheck(t *testing.T) {
})
}
}

func TestMinimumVersion(t *testing.T) {
if got := MinimumVersion(); got != defaultMinimumVersion {
t.Errorf("MinimumVersion() = %q, want %q", got, defaultMinimumVersion)
}
}
Loading