How to set terminationGracePeriodSeconds on the knative activator

[gmintoco]

As outlined in this document if you increase the max-revision-timeout it advises increasing the terminationGracePeriodSeconds on the activator. How do you actually do this?

https://knative.dev/docs/serving/configuration/config-defaults/#max-revision-timeout-seconds:~:text=If%20this%20value%20is%20increased%2C%20the%20activator%27s%20terminationGracePeriodSeconds%20should%20also%20be%20increased%20to%20prevent%20in%2Dflight%20requests%20from%20being%20disrupted.

Thanks,
Gus

[gmintoco]

Perhaps this should be supported on https://knative.dev/docs/install/operator/configuring-serving-cr/#override-system-deployments as a deployment override?

is there any way of doing this in the meantime?

[dprotaso]

cc @houshengbo is this supported via the operator?

[linkvt]

I just checked this, it seems we can't override this.

Compared to the livenessprobe terminationGracePeriodSeconds or more generic overrides I didn't find a reference in the struct definitions: https://github.com/knative/operator/blob/580facdf991a605f00b067a63de955c7823f1470/pkg/apis/operator/base/common.go#L274

I can't decide if we want to support an override but it seems pretty straight forward to implement in case we do, feel free to assign it to me.

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[houshengbo]

Sorry for the late response. It should be configured as

spec:
  ...
  config:
    defaults:
      max-revision-timeout-seconds: "600"

https://knative.dev/docs/install/operator/configuring-with-operator/ This is the introduction to the overriding of the CMs.

[dprotaso]

@houshengbo - I think the question is if I set max-revision-timeout-seconds using that way - is there a way to patch a specific property on the activator deployment resource - eg. they're looking to set terminationGracePeriodSeconds

More generally is there a way to supply arbitrary json patches or something?

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.