Adding stop command

[ffesseler]

It would be interesting to add a stop command to stubb to ... stop the server.
One use-case would be launching the server in integration tests scenarios and shutdown it at the end

[knuton]

Do you mean a stop signal sent via HTTP? I think that might be a neat idea.

First, though: How do you include Stubb in your test setup?

Do you spawn a shell subprocess to run the stubb executable? If so, you could remember the PID and send SIGINT to this PID once your tests ran.

Another option should be running the Stubb Rack app (Stubb.app) using Rack's Thin handler. In that way it should be possible to just serve the requests while your tests are running and have Stubb terminate automatically together with your tests.

[ffesseler]

Yes I'm using a shell subprocess (spawn from a grunt script) to run the stubb binary. I didn't thought about the PID workaround, I'll try it asap!

I don't much about Rack and Rails in general so I need more time to investigate what you said in the last sentence :p

[knuton]

For some reason I had assumed you were working in a Ruby environment. Since you are not, disregard my second hint.

Let me know how it works out with handling the process. I do think that adding some functionality for signal sending via HTTP would be nice to allow less UNIX-savvy to work with Stubb. Signals for stopping and resetting the counter definitely make sense. May add that when I have some time left to spend.

[ffesseler]

Hmm, I was not even able to launch stubb from the grunt build, dunno why.

(FYI, here is the grunt task)

[knuton]

Your grunt task works for me. It seems that the stubb executable can not be found by your system.

Can you run stubb server in the command line? Are you using anything like rbenv or RVM?

[ffesseler]

Yes, stubb server in the command line works fine and I don't use rbenv & RVM.
Note that I'm on a windows computer.

[knuton]

Does the equivalent code work for any command other than stubb?

[ffesseler]

Several things I've discovered :

• It works for any binary available in PATH
• Arguments should be passed as a second parameter var p = spawn('stubb', ['server']);
• It doesn't output results when launching binary that ouput something in the console :

spawn('ls', ['-l']); only shows :

Running "stubb:opts" (stubb) task                                                          
Done, without errors.                           

• When I do spawn('stubb', ['server']); , It stops immediatly and displays the same thing as above (Done, without errors). However I can see a ruby process was created when doing ps -a :
  11356 1 11356 11356 ? 1001 10:49:14 /usr/bin/ruby
curl http://localhost:4040 shows the server is not active though (couldn't connect to host)

[knuton]

Interesting. I have to say that I have never tested Stubb on Windows. Can you curl the server if you run stubb server directly from a prompt?