Bug: Missing error return in checkIfIpIsLive causes nil pointer panic on DNS resolution failure

[meyrevived]

Bug Description

In pkg/ibm/ibmz_helpers.go, the function checkIfIpIsLive has a missing return statement after a failed net.ResolveTCPAddr call. When DNS resolution fails, the error is logged but execution continues to line 86, where server.Network() and server.String() are called on a nil *net.TCPAddr, causing a panic.

Location

File: pkg/ibm/ibmz_helpers.go
Function: checkIfIpIsLive (line 78)
Bug location: lines 83-86

Current Code

server, err := net.ResolveTCPAddr("tcp", ip+":22")
if err != nil {
    log.Error(err, "failed to resolve ip address")
}
conn, err := net.DialTimeout(server.Network(), server.String(), 5*time.Second)

Expected Behavior

When net.ResolveTCPAddr returns an error, the function should return that error immediately instead of proceeding to use the nil server pointer.

Impact

Any DNS resolution failure for an IBM Z or IBM Power host IP address will crash the controller with a nil pointer dereference panic rather than returning a clean error to the caller.

Suggested Fix

Add return err after the error log on line 84, matching the error-handling pattern used elsewhere in the same function (see lines 89 and 93).

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 9:55 AM UTC · Completed 9:57 AM UTC
Commit: 37b10e4 · View workflow run →

[fullsend-ai-triage]

Triage Summary

Severity: High — DNS resolution failures will crash the controller via nil pointer panic.

Verified: The bug is confirmed in pkg/ibm/ibmz_helpers.go in the checkIfIpIsLive function. When net.ResolveTCPAddr fails, the error is logged but execution continues to call methods on the nil *net.TCPAddr pointer, causing a panic.

Root Cause: Missing return err after the error log on line 84.

Recommended Fix: Add return err after the log.Error call, matching the error-handling pattern used elsewhere in the same function (lines 89 and 93).

Proposed Test Case:

func TestCheckIfIpIsLive_UnresolvableAddress(t *testing.T) {
    ctx := context.TODO()
    // Use an address that will fail DNS resolution
    err := checkIfIpIsLive(ctx, "invalid-host-that-does-not-resolve")
    // Should return an error, not panic
    if err == nil {
        t.Error("expected error for unresolvable address, got nil")
    }
}

This is a good first issue — the fix is a single line addition with a clear pattern to follow.

---

Labels: This is a confirmed bug with a clear one-line fix following existing patterns, making it suitable for 'bug', 'good first issue', and 'Review effort 1/5'.

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 9:58 AM UTC · Completed 10:15 AM UTC
Commit: 37b10e4 · View workflow run →