From 7b580a6c9c031ef029f8d23588b7ba29e7538fa0 Mon Sep 17 00:00:00 2001 From: Hammad Majid Date: Thu, 17 Sep 2026 01:27:20 +0500 Subject: [PATCH 1/2] fix(cli): check write errors on command output Co-Authored-By: Claude Fable 5.1 --- internal/cli/cli.go | 6 +++--- internal/cli/init.go | 4 ++-- internal/cli/pick.go | 6 ++++-- internal/cli/scan.go | 4 ++-- internal/cli/version.go | 4 ++-- 5 files changed, 13 insertions(+), 11 deletions(-) diff --git a/internal/cli/cli.go b/internal/cli/cli.go index dc6b53d..4e22aa7 100644 --- a/internal/cli/cli.go +++ b/internal/cli/cli.go @@ -44,7 +44,7 @@ func Run(args []string, stdout, stderr io.Writer) int { return 130 } - fmt.Fprintln(stderr, err) + _, _ = fmt.Fprintln(stderr, err) if isUsageError(err) { return 2 } @@ -62,8 +62,8 @@ func newRootCmd() *cobra.Command { root.RunE = func(cmd *cobra.Command, args []string) error { if v, _ := cmd.Flags().GetBool("version"); v { - fmt.Fprintln(cmd.OutOrStdout(), versionString()) - return nil + _, err := fmt.Fprintln(cmd.OutOrStdout(), versionString()) + return err } return pickRunE(cmd, nil) } diff --git a/internal/cli/init.go b/internal/cli/init.go index dcb83b1..5712c5d 100644 --- a/internal/cli/init.go +++ b/internal/cli/init.go @@ -25,8 +25,8 @@ func newInitCmd() *cobra.Command { if err != nil { return newUsageError(err) } - fmt.Fprint(cmd.OutOrStdout(), script) - return nil + _, err = fmt.Fprint(cmd.OutOrStdout(), script) + return err }, } } diff --git a/internal/cli/pick.go b/internal/cli/pick.go index 60d0a69..9726d12 100644 --- a/internal/cli/pick.go +++ b/internal/cli/pick.go @@ -61,9 +61,11 @@ func pickRunE(cmd *cobra.Command, args []string) error { } out := cmd.OutOrStdout() - fmt.Fprintln(out, abs) + if _, err := fmt.Fprintln(out, abs); err != nil { + return err + } if isTerminal(out) { - fmt.Fprintln(cmd.ErrOrStderr(), initHint) + _, _ = fmt.Fprintln(cmd.ErrOrStderr(), initHint) } return nil } diff --git a/internal/cli/scan.go b/internal/cli/scan.go index fab92e3..ba3f0ca 100644 --- a/internal/cli/scan.go +++ b/internal/cli/scan.go @@ -38,8 +38,8 @@ func newScanCmd() *cobra.Command { return err } - fmt.Fprintf(cmd.OutOrStdout(), "Seeded %d Visits across %d Projects\n", summary.Seeded, summary.Projects) - return nil + _, err = fmt.Fprintf(cmd.OutOrStdout(), "Seeded %d Visits across %d Projects\n", summary.Seeded, summary.Projects) + return err }, } } diff --git a/internal/cli/version.go b/internal/cli/version.go index d5faaed..779feb7 100644 --- a/internal/cli/version.go +++ b/internal/cli/version.go @@ -23,8 +23,8 @@ func newVersionCmd() *cobra.Command { Short: "print the cdd version", Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - fmt.Fprintln(cmd.OutOrStdout(), versionString()) - return nil + _, err := fmt.Fprintln(cmd.OutOrStdout(), versionString()) + return err }, } } From 534ea995f955a42ec3472d9cfcbbacbf427d0284 Mon Sep 17 00:00:00 2001 From: Hammad Majid Date: Thu, 17 Sep 2026 01:27:20 +0500 Subject: [PATCH 2/2] test(picker): range over the query string directly Co-Authored-By: Claude Fable 5.1 --- internal/picker/model_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/picker/model_test.go b/internal/picker/model_test.go index 03b2ff1..f63605d 100644 --- a/internal/picker/model_test.go +++ b/internal/picker/model_test.go @@ -90,7 +90,7 @@ func TestModel_FuzzyFilter(t *testing.T) { next, _ := m.Update(tea.WindowSizeMsg{Width: 120, Height: 40}) m = next.(picker.Model) - for _, r := range []rune("billing") { + for _, r := range "billing" { next, _ = m.Update(tea.KeyPressMsg{Text: string(r)}) m = next.(picker.Model) }