From 1009e12f07d537fa76416a9d95152cf1408a9bf3 Mon Sep 17 00:00:00 2001 From: mdryaan Date: Thu, 28 May 2026 23:12:25 +0000 Subject: [PATCH] fix(worker-slice-config): return error on copier failure instead of continuing with zero-value gateway config Signed-off-by: mdryaan --- service/worker_slice_config_service.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/service/worker_slice_config_service.go b/service/worker_slice_config_service.go index 616071b4e..229e19786 100644 --- a/service/worker_slice_config_service.go +++ b/service/worker_slice_config_service.go @@ -22,7 +22,6 @@ import ( "time" "github.com/jinzhu/copier" - "go.uber.org/zap" k8sErrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ctrl "sigs.k8s.io/controller-runtime" @@ -231,7 +230,7 @@ outer: DeepCopy: true, }) if err != nil { - logger.With(zap.Error(err)).Errorf("Failed to deep copy external gateway configuration") + return ctrl.Result{}, err } // determine Slice gateway service type