Bug: `updateSliceConfig` in hub slice controller does not update `SliceDisplayName` after initial creation

[mdryaan]

📜 Description

pkg/hub/controllers/slice_controller.go, updateSliceConfig (line 271–331): the SliceConfig is only fully populated if meshSlice.Status.SliceConfig == nil. On subsequent reconciles, only specific fields are conditionally updated (SubnetCIDR, QoS, etc.), but SliceDisplayName is never updated after the first creation. If the slice display name changes in the hub, the worker cluster's Slice CR will retain the stale value indefinitely.

👟 Reproduction steps

1. Create a slice with display name "A".
2. Update the display name to "B" in the hub WorkerSliceConfig.
3. Observe that meshSlice.Status.SliceConfig.SliceDisplayName remains "A".

👍 Expected behavior

All fields in SliceConfig that can change should be synced on every reconcile, not only on first creation.

👎 Actual Behavior

SliceDisplayName and SliceType are stuck at their initial values.

🐚 Relevant log output

Version

No response

🖥️ What operating system are you seeing the problem on?

No response

✅ Proposed Solution

Set meshSlice.Status.SliceConfig.SliceDisplayName = spokeSlice.Spec.SliceName unconditionally (outside the == nil guard), mirroring how SliceGatewayServiceType is handled.

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find any similar issue

Code of Conduct

• I agree to follow this project's Code of Conduct