Allow propagation of select annotation from the tenant PVC to the infra PVC

[jaskiratsingh98]

Is your feature request related to a problem? Please describe:
There are situations where it is helpful/necessary to propagate certain annotations from the tenant PVC to the infra PVC.

For example a specific annotation on the tenant PVC could be used to assign it to a specific QoS policy.

Describe the solution you'd like:

1. Create a configmap with the values of annotations allowed to be propagated from tenant to infra
2. The configmap is mounted to the deployment pod
3. A new argument is provided to kvcsi controller pointing to the path of the file (from the configmap) containing the allowlist
4. During CreateVolume these values are propagated to the infra PVC
5. Updates to the configmap should trigger a sync of all existing PVCs to update the annotations for the corresponding infra PVC
6. Update to the annotation value in the tenant PVC should update the annotation value in infra PVC

Describe alternatives you've considered:
A clear and concise description of any alternative solutions or features you've considered.

Additional context:
Add any other context or screenshots about the feature request here.

[awels]

Hi, thanks for the issue (and PR!). I am trying to understand the use case here. Basically you want to be able to put an annotation on a PVC in the tenant cluster, and have that annotation propagate to the appropriate PVC in the infra cluster.

Which annotations can be propagated is controlled by a config map that is passed to the csi controller during startup. This is to prevent the tenant cluster from accidentally or maliciously modifying a PVC in the infra cluster in a way that could interfere with the operation of the infra cluster.

I am guessing these annotations are for some kind of backup or DR solution which helps identify the infra PVCs to backup/keep in sync.

I am just making sure I fully understand the intent here.

[jaskiratsingh98]

Hi @awels, yes this is essentially the use case.

We want to use annotations on the tenant PVC to communicate what kind of snapshot policy the underlying storage should use for example. The user should be able communicate this using annotations on the PVC in the tenant cluster.

[akalenyu]

Hey, thanks for opening both the issue and PR!

Could you elaborate a little about the storage you're using? IIUC annotations can somehow impact provisioning of volumes/snapshots? That seems a little weird to me

Maybe you could benefit from CDI's storage capabilities?
https://github.com/kubevirt/containerized-data-importer/blob/main/doc/onboarding-storage-provisioners.md

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale